impr: Make auto updater work better on Windows

WerWolv · Feb 15, 2025 · 419787e · 419787e
1 parent 2d6da52
commit 419787e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/lib/libimhex/source/api/imhex_api.cpp b/lib/libimhex/source/api/imhex_api.cpp
@@ -936,7 +936,7 @@ namespace hex {
             }
 
             EventImHexClosing::subscribe([executablePath, updateTypeString] {
-                hex::executeCommand(
+                hex::startProgram(
                         hex::format("\"{}\" \"{}\"",
                                     wolv::util::toUTF8String(executablePath),
                                     updateTypeString

diff --git a/lib/libimhex/source/helpers/utils.cpp b/lib/libimhex/source/helpers/utils.cpp
@@ -339,7 +339,7 @@ namespace hex {
     void startProgram(const std::string &command) {
 
 #if defined(OS_WINDOWS)
-        std::ignore = system(hex::format("start {0}", command).c_str());
+        std::ignore = system(hex::format("start \"\" {0}", command).c_str());
 #elif defined(OS_MACOS)
         std::ignore = system(hex::format("open {0}", command).c_str());
 #elif defined(OS_LINUX)

diff --git a/main/updater/source/main.cpp b/main/updater/source/main.cpp
@@ -100,7 +100,7 @@ int installUpdate(const std::string &type, std::fs::path updatePath) {
     };
 
     constexpr static auto UpdateHandlers = {
-        UpdateHandler { "win-msi",          ".msi",  "msiexec /passive /package {}"                             },
+        UpdateHandler { "win-msi",          ".msi",  "msiexec /i {} /qb"                                        },
         UpdateHandler { "macos-dmg",        ".dmg",  "hdiutil attach {}"                                        },
         UpdateHandler { "linux-deb-22.04",  ".deb",  "sudo apt update && sudo apt install -y --fix-broken {}"   },
         UpdateHandler { "linux-deb-23.04",  ".deb",  "sudo apt update && sudo apt install -y --fix-broken {}"   },