fix: auto evaluate doesn't work with undo. #2106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pattern editor was resetting the flag that marked text changes on every frame, but resolving a text change may take more than one frame, so instead I created a function that allows the resetting of the text changed boolean from view pattern editor. Currently, when a pattern is evaluated the pattern editor will lose focus regardless of how evaluation was triggered. This is specially annoying when using f5 or auto-evaluate. Now whenever a pattern is evaluated, focus is given to the pattern editor when evaluation ends.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pattern editor was resetting the flag that marked text changes on every frame, but resolving a text change may take more than one frame, so instead I created a function that allows the resetting of the text changed boolean from view pattern editor.
Currently, when a pattern is evaluated the pattern editor will lose focus regardless of how evaluation was triggered. This is specially annoying when using f5 or auto-evaluate. Now whenever a pattern is evaluated, focus is given to the pattern editor when evaluation ends.
JumptoLine didn't work for empty lines.