Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request - update the cpu target at scheduled time #42

Open
Red-C opened this issue Mar 1, 2021 · 2 comments · May be fixed by #43
Open

Feature Request - update the cpu target at scheduled time #42

Red-C opened this issue Mar 1, 2021 · 2 comments · May be fixed by #43
Assignees
@ericuldall
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Red-C
Copy link

Red-C commented Mar 1, 2021

thanks for having this scheduled-scaler, it's super useful and we have been used in many of clusters.

instead of just updating min & max, can we also have a functionality of overwriting the cpu target? lowering the cpu target could trigger a hpa upscale without wasting too many resource.

please let me know your thought on this.
@ericuldall
Copy link
Contributor

I think that would definitely be in scope for this resource. I'll tag this as a feature request.
I don't have a lot of dev time for this project as of now but I'm happy to get a PR merged in if you're willing/able to work on one.

@ericuldall ericuldall added enhancement New feature or request help wanted Extra attention is needed labels Mar 1, 2021
@Red-C Red-C linked a pull request Mar 15, 2021 that will close this issue
Open
@ericuldall ericuldall linked a pull request Mar 16, 2021 that will close this issue
[scheduled-scaler]support cpu target based upscale #43
Open
@ericuldall ericuldall self-assigned this Mar 7, 2022
@ericuldall
Copy link
Contributor

Hey @Red-C Sorry for this PR not getting merged. We're currently in the process of migrating scheduled scaler to v1 and upgrading to a newer version of the kubernetes sdk at which point I'll be reviewing this PR to see if it still works with the updated code.

Also going to be rolling up build automation so that we can more quickly and safely get PR's merged in the future.

Just wanted you to know I didn't forget about this and I hope you're still finding the project useful as we'll be improving it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericuldall ericuldall

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[scheduled-scaler]support cpu target based upscale Red-C/scheduled-scaler
2 participants
@ericuldall @Red-C