Bug/maxfee index overflow (#42)

* bug: index max fee assignment overflow * chore/update examples with MAX_PATH_HOPS
White-Whale-Defi-Platform · Feb 15, 2023 · ed059be · ed059be
1 parent c547c8f
commit ed059be
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/.env.juno.example b/.env.juno.example
@@ -6,7 +6,7 @@ PROFIT_THRESHOLD="10000"
 # LOGGING ENVIRONMENT VARIABLES 
 # SLACK_TOKEN = 
 # SLACK_CHANNEL = 
-
+MAX_PATH_HOPS="4"
 # # SKIP SPECIFIC ENVIRONMENT VARIABLES
 USE_SKIP = "1"
 SKIP_URL= "http://juno-1-api.skip.money"

diff --git a/.env.terra.example b/.env.terra.example
@@ -4,7 +4,7 @@ WALLET_MNEMONIC="" ##change this
 USE_MEMPOOL="1"
 GAS_USAGE_PER_HOP="700000" #defines the gas usage per hop, 2 hop arb pays 1400000 gas, 3 hop will pay 2100000 etc
 PROFIT_THRESHOLD="5000"
-
+MAX_PATH_HOPS="4"
 
 ##LOGGING ENVIRONMENT VARIABLES, optional
 #SLACK_TOKEN = ""

diff --git a/src/core/types/arbitrageloops/mempoolLoop.ts b/src/core/types/arbitrageloops/mempoolLoop.ts
@@ -142,7 +142,9 @@ export class MempoolLoop {
 
 		const TX_FEE =
 			this.botConfig.txFees.get(arbTrade.path.pools.length) ??
-			Array.from(this.botConfig.txFees.values())[this.botConfig.txFees.size];
+
+			Array.from(this.botConfig.txFees.values())[this.botConfig.gasFees.size - 1];
+
 
 		// sign, encode and broadcast the transaction
 		const txRaw = await this.botClients.SigningCWClient.sign(

diff --git a/src/core/types/arbitrageloops/skipLoop.ts b/src/core/types/arbitrageloops/skipLoop.ts
@@ -125,7 +125,8 @@ export class SkipLoop extends MempoolLoop {
 		//if gas fee cannot be found in the botconfig based on pathlengths, pick highest available
 		const TX_FEE =
 			this.botConfig.txFees.get(arbTrade.path.pools.length) ??
-			Array.from(this.botConfig.txFees.values())[this.botConfig.txFees.size];
+			Array.from(this.botConfig.txFees.values())[this.botConfig.gasFees.size - 1];
+
 		const txRaw: TxRaw = await this.botClients.SigningCWClient.sign(
 			this.account.address,
 			msgs,