Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade skipjs and cosmjs dependencies #54

Open
wants to merge 1 commit into
base: main-archived
Choose a base branch
from

Conversation

carlthelooper
Copy link
Contributor

Description and Motivation

Upgrade to the latest skipjs and cosmjs dependencies.

Currently skip has limited access to the suggested method for signing a bundle which causes an issue in typescript that needs to be ignored. Would prefer an alternative but put this PR up for discussion.

Related Issues


Checklist:

  • I have read Migaloo's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing (if any).
  • I updated/added relevant documentation.
  • The code is formatted properly using eslint

@carlthelooper carlthelooper marked this pull request as ready for review February 18, 2023 13:01
@carlthelooper carlthelooper mentioned this pull request Feb 22, 2023
@silvermind
Copy link
Contributor

what's the state on this? seems merged to an old branch. main is still using "@skip-mev/skipjs": "1.1.0",
https://github.com/White-Whale-Defi-Platform/white-whale-bots/blob/main/package.json

The changes to src/core/types/arbitrageloops/skipLoop.ts seems still valid on update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants