fix(smart-contracts): update slippage tolerance to work with N coins

White-Whale-Defi-Platform · May 28, 2024 · 59e034a · 59e034a
1 parent eab7ea1
commit 59e034a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/contracts/liquidity_hub/pool-manager/src/error.rs b/contracts/liquidity_hub/pool-manager/src/error.rs
@@ -162,6 +162,9 @@ pub enum ContractError {
 
     #[error("Invalid swap route: {0}")]
     InvalidSwapRoute(SwapRoute),
+
+    #[error("Invalid pool assets length, expected {expected} got {actual}")]
+    InvalidPoolAssetsLength { expected: usize, actual: usize },
 }
 
 impl From<semver::Error> for ContractError {

diff --git a/contracts/liquidity_hub/pool-manager/src/helpers.rs b/contracts/liquidity_hub/pool-manager/src/helpers.rs
@@ -530,6 +530,12 @@ pub fn assert_slippage_tolerance(
                 }
             }
             PoolType::ConstantProduct => {
+                if deposits.len() != 2 || pools.len() != 2 {
+                    return Err(ContractError::InvalidPoolAssetsLength {
+                        expected: 2,
+                        actual: deposits.len(),
+                    });
+                }
                 if Decimal256::from_ratio(deposits[0], deposits[1]) * one_minus_slippage_tolerance
                     > Decimal256::from_ratio(pools[0], pools[1])
                     || Decimal256::from_ratio(deposits[1], deposits[0])