Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/vault manager poc #229

Merged
merged 58 commits into from
Dec 13, 2023
Merged

Conversation

kerber0x
Copy link
Contributor

Description and Motivation

This PR merges the vault manager job into the v2_contracts branch.

Related Issues


Checklist:

  • I have read Migaloo's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The code is formatted properly cargo fmt --all --.
  • Clippy doesn't report any issues cargo clippy -- -D warnings.
  • I have regenerated the schemas if needed cargo schema.

@kerber0x kerber0x force-pushed the feat/vault-manager-poc branch from 9e2fdaa to b8ae75e Compare December 12, 2023 15:45
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 260 lines in your changes are missing coverage. Please review.

Comparison is base (3e4b14f) 94.51% compared to head (edbaac8) 94.25%.

Files Patch % Lines
...kages/white-whale/src/pool_network/mock_querier.rs 45.94% 60 Missing ⚠️
.../liquidity_hub/vault-manager/tests/common/suite.rs 79.77% 54 Missing ⚠️
...s/liquidity_hub/vault-manager/tests/integration.rs 97.67% 22 Missing ⚠️
...iquidity_hub/vault-manager/src/manager/commands.rs 84.07% 18 Missing ⚠️
packages/white-whale/src/lp_common.rs 48.14% 14 Missing ⚠️
packages/white-whale/src/tokenfactory/common.rs 0.00% 13 Missing ⚠️
packages/white-whale/src/tokenfactory/mint.rs 0.00% 10 Missing ⚠️
packages/white-whale/src/vault_manager.rs 63.63% 8 Missing ⚠️
...kages/white-whale/src/tokenfactory/create_denom.rs 0.00% 7 Missing ⚠️
.../liquidity_hub/vault-manager/src/vault/commands.rs 92.40% 6 Missing ⚠️
... and 21 more
Additional details and impacted files
@@                   Coverage Diff                    @@
##           release/v2_contracts     #229      +/-   ##
========================================================
- Coverage                 94.51%   94.25%   -0.26%     
========================================================
  Files                       218      238      +20     
  Lines                     24720    26680    +1960     
========================================================
+ Hits                      23364    25148    +1784     
- Misses                     1356     1532     +176     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kerber0x kerber0x merged commit 19b1a52 into release/v2_contracts Dec 13, 2023
4 of 6 checks passed
@kerber0x kerber0x deleted the feat/vault-manager-poc branch December 13, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant