Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with death snapshots and restore of any snapshots after death on Fabric #398

Open
Smalldero opened this issue Oct 9, 2024 · 0 comments
Labels
platform: fabric This issue is specific to Fabric status: needs testing This needs video proof and testing

Comments

@Smalldero
Copy link

Description

I have problems with death snapshots and restore of any snapshots after death on the Fabric version (3.7+mc.1.21.1)

Reproduction

  • If I die, the death Snaphot is created. But it does not contain any loot (items_to_save is set to DROPS)
    • If I understand the mechanic correctly, it should have all loot in the snapshot that was dropped on my death
    • I died in lava, does that have someting to do with it? After my death there was still loot around the lava, so technically dropped loot
  • If I then restore antoher snapshot that still has loot it fills my inventory as expected. But if I move something in the inventory everything disappears. Same if I disconnect from the server and reconnect - everything disappears.
    • This only happens on restore after I died. If I dont die then the restore works fine

Test environment

Everything was tested in a docker environment. So I could send you the whole compose with the volumes if you want to have the exact same test setup (320MB zip file). But I tried it multiple times with new setups an everytime this happens, so I guess you should be able to reproduce it on your own with a default Fabric Setup.

System Setup (All Docker containers):

  • New MySQL Server with new Database (8.0.39-bookworm)
  • New Redis (6.2-alpine)
  • Two new Fabric Servers (1.21.1)
    • Mods used are Fabric API (0.105.0+1.21.1), Fabric Proxy-Lite (2.9.0) and of course HuskSync (3.7+mc.1.21.1)
  • New Velocity Server (3.4.0)
    • No Plugins
      (New means a clean test environment)

HuskSync config changes:

  • MySQL connection data
  • Redis connection data
  • Added DEATH to auto_pinned_save_causes
  • Enabled save_on_death
  • Set max_user_data_snapshots to 168
  • Set snapshot_backup_frequency to 1

If you need any further information let me know. Thanks!

@WiIIiam278 WiIIiam278 added status: needs testing This needs video proof and testing platform: fabric This issue is specific to Fabric labels Oct 11, 2024
@WiIIiam278 WiIIiam278 changed the title Problems with death snapshots and restore of any snapshots after death (Fabric) Problems with death snapshots and restore of any snapshots after death on Fabric Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: fabric This issue is specific to Fabric status: needs testing This needs video proof and testing
Projects
None yet
Development

No branches or pull requests

2 participants