Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination offset is 1 instead of being configurable #42

Closed
romulobruno opened this issue Mar 21, 2024 · 1 comment · Fixed by #43
Closed

Pagination offset is 1 instead of being configurable #42

romulobruno opened this issue Mar 21, 2024 · 1 comment · Fixed by #43

Comments

@romulobruno
Copy link

I just configured my tap to use offset_paginator style:

  next_page_token_path: $
  pagination_request_style: offset_paginator
  pagination_response_style: style1
  pagination_page_size: 100
  pagination_total_limit_param: totalCount
  store_raw_json_message: false
  backoff_type: header
  backoff_param: ratelimit-reset

But i discovered that the first item was never returned.

After asking for help on slack, I was informed that the 1 value (first offset) seems to be hardcoded here:

tap-rest-api-msdk/tap_rest_api_msdk/streams.py

Line 306 in 4f87c1a

start_value=1,

Could you fix it by making this value configurable? (I tested it locally by changing the value to 0 and it worked.)
@romulobruno romulobruno changed the title Pagination offset is 1 instead of being configurable or 0 Pagination offset is 1 instead of being configurable Mar 21, 2024
@edgarrmondragon edgarrmondragon mentioned this issue Mar 22, 2024
Merged
@romulobruno
Copy link
Author

It worked as expected after setting the variable pagination_initial_offset to 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add pagination_initial_offset setting edgarrmondragon/tap-rest-api-msdk
1 participant
@romulobruno