Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when using 'simple_offset_paginator' request style #51

Closed
dannydeut opened this issue Aug 12, 2024 · 1 comment · Fixed by #52
Closed

Error when using 'simple_offset_paginator' request style #51

dannydeut opened this issue Aug 12, 2024 · 1 comment · Fixed by #52

Comments

@dannydeut
Copy link
Contributor

dannydeut commented Aug 12, 2024

I tried using this extractor with pagination_request_style: simple_offset_paginator. However when I test the config or run the extractor I get the error below.

TypeError: __init__() missing 1 required positional argument: 'page_size'

I couldn't figure out what I was doing wrong, but after some digging in the code I found out that the plugin contains a bug(?). I forked the repo, applied the 'fix' and the extractor is working me now. I am new to Meltano and not really a python developer, so leave up to the maintainers of this extractor what to do with this. The fix can be found below.

https://github.com/dannydeut/tap-rest-api-msdk/commit/60ef665b375f58b72a6162a50ef99a3ca4828964

BTW great work on this extractor, works very nice.

@jlloyd-widen
Copy link
Contributor

@dannydeut Thanks for contributing! Would you mind submitting a PR with this issue (#51) in the description?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants