Update Singer-SDK 0.47, min Python 3.7.1 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @s7clarke10 . Sorry for my slow response on this. I hope to get to this PR some time this week. |
|
Hi Josh,
Thanks for that all good, I’m working on a fork at the moment and it is working well - I’m able to use the JSONPath extensions to filter now.
I am looking at two possible extensions which I would like to add to the TAP, but haven’t had the time to do so yet.
1. Support for OAuth, I need to grab the data dictionary from Salesforce and need an OAuth flow to support it. This is a simple REST end-point and this TAP will work well when OAuth authentication is supported.
2. Adding another style of determining a Pagination next token. My FHIR API returns the next token as a full URL, I will need to parse it to pull the tokens. If done in a generic manner, I feel it could be implemented as another style.
Do these proposals sound like good additional features.
Cheers
Steve
… On 11/05/2022, at 9:17 AM, jlloyd-widen ***@***.***> wrote:
Thanks @s7clarke10 . Sorry for my slow response on this. I hope to get to this PR some time this week.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
|
@s7clarke10 I like both proposals. Both are things that I don't have any ability to develop against since I don't have representative APIs. Feel free to submit them in separate PRs and make sure to include documentation in the readme on how to use them. |
jlloyd-widen
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Josh,
I have updated the pyproject.toml file to support the latest Singer-SDK 0.47. I was recently trying to use JSON Path and found that the JSON Path extension were not working. Edgar @meltano has kindly introduced this feature when I raised this with Meltano to support JSON Path extensions in the Singer-SDK 0.46 https://gitlab.com/meltano/sdk/-/issues/361 .
Are you able accept an update to the latest version of the SDK to allow me to use JSON Path extensions with your TAP please?
Note: Due to the Singer-SDK dependencies, the minimum supported Python version has been updated to 3.7.1.
Kind Regards
Steve