From f4c71d2e0d45efd61f988f4fb7cebd12dba5f136 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Karol=20Tata=C5=82a?= Date: Fri, 3 Nov 2017 09:44:35 +0100 Subject: [PATCH] XW-4222 | Fix comscore tracking --- app/modules/video-players/jwplayer.js | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/modules/video-players/jwplayer.js b/app/modules/video-players/jwplayer.js index b13938b5a28..eb537f690ef 100644 --- a/app/modules/video-players/jwplayer.js +++ b/app/modules/video-players/jwplayer.js @@ -2,6 +2,7 @@ import Ads from '../ads'; import BasePlayer from './base'; import JWPlayerVideoAds from './jwplayer-video-ads'; import {track} from '../../utils/track'; +import config from '../../config/environment'; export const jwPlayerAssets = { styles: '/mobile-wiki/assets/jwplayer/index.css', @@ -57,8 +58,7 @@ export default class JWPlayer extends BasePlayer { track(data); }, setCustomDimension: M.tracker.UniversalAnalytics.setDimension, - // todo verify after Stanley's response - comscore: false + comscore: config.environment === 'production' }, autoplay: { enabled: this.params.autoplay, diff --git a/package.json b/package.json index 00d11cf2a3a..55f88e9d158 100644 --- a/package.json +++ b/package.json @@ -38,7 +38,7 @@ "fastboot": "github:wikia/fastboot#582162a5e2eb39c2d94f857e53ee0efff4544447", "fastboot-app-server": "1.0.1", "html5-skin": "github:wikia/html5-skin#84574003c0cf2fa6de499bd6e7423a2a37681e44", - "jwplayer-fandom": "github:wikia/jwplayer-fandom#1.0.7", + "jwplayer-fandom": "github:wikia/jwplayer-fandom#1.0.8", "method-override": "2.3.10", "newrelic": "2.2.1", "on-headers": "1.0.1",