Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to catch more exceptions during OpenSearch indexing #842

Closed
naknomum opened this issue Oct 23, 2024 · 2 comments
Closed

try to catch more exceptions during OpenSearch indexing #842

naknomum opened this issue Oct 23, 2024 · 2 comments
Assignees
Labels
opensearch anything that touches on opensearch project_support devops, build changes, etc etc
Milestone

Comments

@naknomum
Copy link
Member

Expected Behavior
A user does something which triggers OpenSearch indexing (creating or modifying an Encounter) but something goes awry with OpenSearch -- the user's action should still complete, if possible.

Current Behavior
User does the thing, but OpenSearch exception bubbles up to browser and action is only partially completed.

Testing Notes
It is extremely difficult to replicate the behavior that causes OpenSearch "to go awry"; so this will be the challenge. The incident which triggered the ticket was a mismatch between OpenSearch docker image version and pom.xml configuration (which manifested as a json parsing problem). Good luck future-jon.

@naknomum naknomum added the bug something's broken! label Oct 23, 2024
@naknomum naknomum self-assigned this Oct 23, 2024
@TanyaStere42 TanyaStere42 added the opensearch anything that touches on opensearch label Oct 30, 2024
@TanyaStere42
Copy link
Member

TanyaStere42 commented Nov 26, 2024

make this into code guidelines because this is now an NFR WildMeOrg/wildbook-docs#98

@TanyaStere42 TanyaStere42 added this to the 10.6.0 milestone Nov 26, 2024
@TanyaStere42 TanyaStere42 added project_support devops, build changes, etc etc and removed bug something's broken! labels Nov 26, 2024
@naknomum
Copy link
Member Author

naknomum commented Feb 5, 2025

created a PR in docs to address best practices here, so closing this ticket.

OpenSearch has now been through several iterations, so general cases of exceptions are now mostly being caught (and often dumps stacktrace). this narrows down improvements and future development to cases covered in the docs: basically try to prevent invalid data from derailing the entire document's indexing -- stop it with code before it can be an exception.

@naknomum naknomum closed this as completed Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
opensearch anything that touches on opensearch project_support devops, build changes, etc etc
Projects
None yet
Development

No branches or pull requests

2 participants