Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Rebase off of Sway 1.10.1 #360

Closed
markstos opened this issue Oct 28, 2024 · 8 comments
Closed

Feature: Rebase off of Sway 1.10.1 #360

markstos opened this issue Oct 28, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@markstos
Copy link
Contributor

Sway 1.10 has been released. It would be great if swayfx could be rebased to be based on the latest version of Sway and wlroots.

@markstos markstos added the enhancement New feature or request label Oct 28, 2024
@ErikReider
Copy link
Collaborator

Requires wlrfx/scenefx#55

@WillPower3309
Copy link
Owner

Also wlrfx/scenefx#69 and wlrfx/scenefx#33

@markstos
Copy link
Contributor Author

markstos commented Nov 8, 2024

I just tried upgrading from Sway 1.9 to 1.10 on a machine and it was a hot mess. Fuzzel would no longer launch, my wmfocus window switching utility became unreliable and sometimes I couldn't click into terminals and type.

That is to say, I wouldn't worry about rushing this. There are alread Sway several issues tagged with 1.10.1, and I wouldn't recommend targeting any earlier release of the 1.10 series than 1.10.1.

@WillPower3309
Copy link
Owner

I just tried upgrading from Sway 1.9 to 1.10 on a machine and it was a hot mess. Fuzzel would no longer launch, my wmfocus window switching utility became unreliable and sometimes I couldn't click into terminals and type.

That is to say, I wouldn't worry about rushing this. There are alread Sway several issues tagged with 1.10.1, and I wouldn't recommend targeting any earlier release of the 1.10 series than 1.10.1.

Agreed! We discussed this a bit on discord, will wait for 1.10.1 to avoid all the mess

@WillPower3309 WillPower3309 changed the title Feature: Rebase off of Sway 1.10 Feature: Rebase off of Sway 1.10.1 Nov 13, 2024
@markstos
Copy link
Contributor Author

All the blockers for this have been resolved. The three PRS it depended on have been merged and Sway 1.10.1 was released.

@WillPower3309
Copy link
Owner

All the blockers for this have been resolved. The three PRS it depended on have been merged and Sway 1.10.1 was released.

Need to merge #367 first. Then 1.10.1 will be a small + fast follow-up

@WillPower3309
Copy link
Owner

We decided to do a 1.10.0 merge first since it effectively required rewriting swayfx

@ErikReider
Copy link
Collaborator

Fixed by #382

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants