Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pack('S*') instead of .chr so full utf-16 can be supported #283

Closed
wants to merge 3 commits into from
Closed

Use pack('S*') instead of .chr so full utf-16 can be supported #283

wants to merge 3 commits into from

Conversation

cork
Copy link

@cork cork commented Feb 27, 2018 •
edited
Loading

This is to fix #282. Following has been tested, I hope I haven't missed a case.

> puts shell.run("echo \"works 🌓?\"").output
works 🌓?
> puts shell.run("echo \"works عربية‎?\"").output
works عربية‎?
> puts shell.run("echo \"works 的手机告的世全所回广讲说跟?\"").output
works 的手机告的世全所回广讲说跟?

@cork cork force-pushed the fix_unicode_parsing branch from d1d8a40 to 7f7a3b0 Compare March 1, 2018 08:05
@cork cork force-pushed the fix_unicode_parsing branch from 7f7a3b0 to dd8b5ac Compare March 1, 2018 08:22
@cork cork changed the title Use pac('S*') instead of .chr so full utf-16 can be supported Use pack('S*') instead of .chr so full utf-16 can be supported Mar 1, 2018
@mwrock mwrock mentioned this pull request Oct 16, 2018
Merged
@mwrock
Copy link
Member

mwrock commented Oct 16, 2018

carried by #290

@mwrock mwrock closed this Oct 16, 2018
@cork cork deleted the fix_unicode_parsing branch November 27, 2019 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Powershell echo of higher unicode crashes PipelineOutput.extract_out_string
2 participants
@cork @mwrock