You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The definition of IR to refer to the Wizchip's interrupt register causes build errors when trying to build for an STM32G4xx series microcontroller using ST's HAL and CMSIS common code.
causes this variable name to be replaced with a numeric constant by the C preprocessor. It is generally considered best practice to namespace #defines in libraries to avoid this, for instance this define in the Wiznet code could be named WIZCHIP_REG_IR or similar instead of just IR.
The text was updated successfully, but these errors were encountered:
The definition of IR to refer to the Wizchip's interrupt register causes build errors when trying to build for an STM32G4xx series microcontroller using ST's HAL and CMSIS common code.
If you look at
https://github.com/STMicroelectronics/STM32CubeG4/blob/c4132af65fe74ddd7f54aced85a0f4acce736405/Drivers/CMSIS/Device/ST/STM32G4xx/Include/stm32g474xx.h#L271
you'll see that IR is the name of a variable inside a struct for the STM's CAN-FD controller, but the
#define
in Wiznet's code atioLibrary_Driver/Ethernet/W5500/w5500.h
Line 270 in 3847fb3
#define
s in libraries to avoid this, for instance this define in the Wiznet code could be namedWIZCHIP_REG_IR
or similar instead of justIR
.The text was updated successfully, but these errors were encountered: