-
Notifications
You must be signed in to change notification settings - Fork 2
New UI Stripe #735
base: stripe
Are you sure you want to change the base?
New UI Stripe #735
Conversation
# def __init__(self, *args, **kwargs): | ||
# super().__init__(*args, **kwargs) | ||
# for field_name in self.fields: | ||
# self.fields[field_name].widget.attrs['placeholder'] = '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rptrchv plz check this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added myself to the reviewers list, but (if it's not very urgent) I'll be able to get to it in few days only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the UI is in this sprint. Not adding support for Stripe itself.
@@ -95,14 +162,16 @@ <h5 class="card-title mb-0">Billing</h5> | |||
if (payment_plan_id === '1') { // Enabled standard plan. | |||
$('.card-form-group').removeClass('d-none'); // Unhide card section. | |||
handle_stripe_submission = true; | |||
document.getElementById('id_card_element').scrollIntoView({ behavior: 'smooth' }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scrollIntoView
options are not supported in Safari. For RA page I used
$('html,body').animate({scrollTop: $('#element').offset().top});
and it looks like smooth scroll.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was working on my Safari, but I changed to Jquery.
width: 40px; | ||
color: #2460c8; | ||
z-index: 999; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be moved to .scss?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! Done.
@@ -80,6 +178,7 @@ <h1 id="register-title">Register</h1> | |||
$('#id_nodes_number').val($('#remembered-nodes-number').val()); | |||
$('.free-hidden').removeClass('d-none'); | |||
handle_stripe_submission = true; | |||
document.getElementById('id_card_element').scrollIntoView({ behavior: 'smooth' }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see the similar comment about scrollIntoView
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
New fail message page Change scrolToView for Jquery Move css to scss
This PR adapts Stripe elements to New-UI and, changes related elements and css classes.
WARN: Check #734 before merging.
Profile_Billing:
https://www.loom.com/share/e1f6ac19b7df49f989bed133cce655a7
Register
https://www.loom.com/share/6963c27ccd9f4acf948b849aaad835e3
Success message for Register in Dashboard.
Failed Message in NEW tab
closes #728,
closes #736