Skip to content
This repository has been archived by the owner on Sep 16, 2022. It is now read-only.

New UI Stripe #735

Open
wants to merge 3 commits into
base: stripe
Choose a base branch
from
Open

New UI Stripe #735

wants to merge 3 commits into from

Conversation

dvidotti
Copy link

@dvidotti dvidotti commented Feb 22, 2020

This PR adapts Stripe elements to New-UI and, changes related elements and css classes.
WARN: Check #734 before merging.

Profile_Billing:

https://www.loom.com/share/e1f6ac19b7df49f989bed133cce655a7

Captura de Tela 2020-02-22 às 11 12 42

Captura de Tela 2020-02-22 às 11 13 29

Captura de Tela 2020-02-22 às 11 13 12

Captura de Tela 2020-02-22 às 17 06 08

Captura de Tela 2020-02-22 às 17 06 20

Register

https://www.loom.com/share/6963c27ccd9f4acf948b849aaad835e3

Captura de Tela 2020-02-22 às 17 49 00
Captura de Tela 2020-02-22 às 17 49 16

Captura de Tela 2020-02-22 às 11 26 34

Success message for Register in Dashboard.
Captura de Tela 2020-02-22 às 09 44 35

Failed Message in NEW tab

Captura de Tela 2020-02-29 às 18 03 37

closes #728,
closes #736

This was referenced Feb 22, 2020
# def __init__(self, *args, **kwargs):
# super().__init__(*args, **kwargs)
# for field_name in self.fields:
# self.fields[field_name].widget.attrs['placeholder'] = ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rptrchv plz check this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added myself to the reviewers list, but (if it's not very urgent) I'll be able to get to it in few days only.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the UI is in this sprint. Not adding support for Stripe itself.

@@ -95,14 +162,16 @@ <h5 class="card-title mb-0">Billing</h5>
if (payment_plan_id === '1') { // Enabled standard plan.
$('.card-form-group').removeClass('d-none'); // Unhide card section.
handle_stripe_submission = true;
document.getElementById('id_card_element').scrollIntoView({ behavior: 'smooth' });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scrollIntoView options are not supported in Safari. For RA page I used
$('html,body').animate({scrollTop: $('#element').offset().top}); and it looks like smooth scroll.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was working on my Safari, but I changed to Jquery.

width: 40px;
color: #2460c8;
z-index: 999;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be moved to .scss?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Done.

@@ -80,6 +178,7 @@ <h1 id="register-title">Register</h1>
$('#id_nodes_number').val($('#remembered-nodes-number').val());
$('.free-hidden').removeClass('d-none');
handle_stripe_submission = true;
document.getElementById('id_card_element').scrollIntoView({ behavior: 'smooth' });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see the similar comment about scrollIntoView.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@rptrchv rptrchv self-requested a review February 27, 2020 07:43
New fail message page
Change scrolToView for Jquery
Move css to scss
@vpetersson vpetersson mentioned this pull request Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants