Implement Stripe #816
Implement Stripe #816
Conversation
There was a problem hiding this comment.
Code:
- Lots of reformatting, can't tell if the reformatted code differs from the original
- Some commented out code
Settings page:
- "trialing" should either be capitalized or changed to something like "Trial" or "In Trial" @vpetersson wdyt?
- Monthly Charge should show currency
- UX issue: you can cancel subscription if you switch from Standard too Free. But you have to know that. There is no "Cancel Subscription" button, but I believe there should be. @vpetersson wdyt?
- (Safari only): white square instead of an icon:
Nodes page
I believe this warning is not completely styled. It doesn't agree with dialog boxes on other pages. Looks nice though.
| if device.payment_status == 'unpaid': | ||
| return HttpResponseForbidden() | ||
| context = self.get_context_data(**kwargs) | ||
| return self.render_to_response(context) |
There was a problem hiding this comment.
Deprecated since 2.0
| if self.object.payment_status == 'unpaid': | ||
| return HttpResponseForbidden() | ||
| context = self.get_context_data(object=self.object) | ||
| return self.render_to_response(context) |
There was a problem hiding this comment.
Deprecated since 2.0
| @@ -571,6 +564,8 @@ def _actions(self, device_pk=None): | |||
| actions_by_id = defaultdict(list) | |||
| affected_devices = set() | |||
| for ra in active_actions: | |||
| if ra.device.payment_status == 'unpaid': | |||
| continue # Filter out actions for unpaid devices. | |||
There was a problem hiding this comment.
This is very slow. Slows down RA page generation by 3x. Needs optimization: either prefetch_related or annotation.
|
Another issue I've found: |
a-martynovich
force-pushed
the
stripe-2020-03
branch
from
ff0aed9
to
a247a30
Compare
|
Rebased the branch on top of master. All issues remain. |
Right, but does it include the code base from all the other PRs? |
Correct. It should be title cased.
Having a cancel feature would indeed make sense here.
Yeah it doesn't seem to have the same style guide as the rest of the pages, but I can live with that for now. |
No description provided.