Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.comm does not allow alignment specification #8

Open
WojciechMigda opened this issue Jan 18, 2014 · 2 comments
Open

.comm does not allow alignment specification #8

WojciechMigda opened this issue Jan 18, 2014 · 2 comments
Assignees
Labels

Comments

@WojciechMigda
Copy link
Owner

when the .comm directive is encountered s_comm handler in the read.c/potable table is invoked. It does not handle the alignment argument.

@WojciechMigda
Copy link
Owner Author

resolved on bu-2.24-tic6x-coff
commit 1fe9bce

WojciechMigda added a commit that referenced this issue Jan 18, 2014
@ghost ghost assigned WojciechMigda Jan 19, 2014
@WojciechMigda WojciechMigda reopened this Jan 19, 2014
@WojciechMigda
Copy link
Owner Author

ELF:
obj-elf.c/elf_pseudo_table:

{"comm", obj_elf_common, 0},
void
obj_elf_common (int is_common)
{
  if (flag_mri && is_common)
    s_mri_common (0);
  else
    s_comm_internal (0, elf_common_parse);
}

read.c/s_comm_internal(int param, symbolS _(_comm_parse_extra) (int, symbolS *, addressT))
obj-elf.c/elf_common_parse(int ignore ATTRIBUTE_UNUSED, symbolS *symbolP, addressT size)

///.comm symbol,size,alignment
s_comm_internal:
reads .comm symbol,size and calls comm_parse_extra arg for the rest of the line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant