tries fixing tests

WolfgangFahl · Feb 25, 2024 · d26f233 · d26f233
1 parent 0b33020
commit d26f233
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/ceurws/ceur_ws.py b/ceurws/ceur_ws.py
@@ -365,6 +365,7 @@ def load(self):
         """
         if Download.needsDownload(CEURWS.CACHE_FILE):
             self.loadFromIndexHtml()
+            self.store()
         else:
             self.loadFromBackup()
 

diff --git a/ceurws/wikidatasync.py b/ceurws/wikidatasync.py
@@ -135,11 +135,7 @@ def prepareVolumeManager(self):
         prepare my volume manager
         """
         self.vm = VolumeManager()
-        if Download.needsDownload(CEURWS.CACHE_FILE):
-            self.vm.loadFromIndexHtml(force=True)
-            self.vm.store()
-        else:
-            self.vm.loadFromBackup()
+        self.vm.load()
         self.volumesByNumber, _duplicates = LOD.getLookup(self.vm.getList(), "number")
         self.volumeList = self.vm.getList()
         self.volumeCount = len(self.volumeList)
@@ -148,7 +144,6 @@ def prepareVolumeManager(self):
         for volume_number in reverse_keys:
             volume = self.volumesByNumber[volume_number]
             self.volumeOptions[volume.number] = f"Vol-{volume.number}:{volume.title}"
-
 
     def addVolume(self, volume: Volume):
         """

diff --git a/tests/test_indexhtml_scrape.py b/tests/test_indexhtml_scrape.py
@@ -46,8 +46,11 @@ def volumesAsCsv(self, volumes, minVolumeNumber, maxVolumeNumber):
                 )
 
     def testVolumeManagerFromHtml(self):
+        """
+        test loading the volume manager from HTML
+        """
         vm = VolumeManager()
-        vm.loadFromIndexHtml(force=True)
+        vm.loadFromIndexHtml()
         withStore = False
         if withStore:
             vm.store()