Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types and PHP version-related issues #62

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

reimic
Copy link
Collaborator

@reimic reimic commented Mar 5, 2024

What does this PR do?

  • Fixes an error where the Resource Resolver... Resolving process was erroneously typed and caused PHP to confuse itself.
  • Fixes types to match PHP 7.0 coding standards.
  • Fixed some other small issues in affected classes that would cause coding standards to signal warnings.
  • Fixed a member access issue caused by the Compiler.

@reimic
Copy link
Collaborator Author

reimic commented Mar 5, 2024

Current state:

PS D:\blueprints> php blueprint_compiling.php
 [===>------------------------]  13/100 -- Extracting WordPressPHP Warning:  rename(D:\blueprints\new-wp\tmp\tmpCAB2.tmp/wordpress/wp-admin,D:/blueprints/new-wp/wp-admin): Access is denied (code: 5) in D:\blueprints\src\WordPress\
Blueprints\functions.php on line 52
PHP Fatal error:  Uncaught Symfony\Component\Filesystem\Exception\IOException: Failed to move the file from D:\blueprints\new-wp\tmp\tmpCAB2.tmp/wordpress/wp-admin at D:/blueprints/new-wp/wp-admin in D:\blueprints\src\WordPress\Bl
ueprints\functions.php:54

This starts to look like a #60 issue.

@adamziel
Copy link
Collaborator

adamziel commented Mar 5, 2024

@reimic let's clean up this PR and handle the new issue separately

@reimic
Copy link
Collaborator Author

reimic commented Mar 5, 2024

@adamziel Ok. In what state would you like the PR?

I've changed the core PHP rename to Symfony's version which handles Windows cases better. This allowed me to realize, that before each new run of any blueprint I have to manually clear the generated new-wp file. (This is a callback to our discussion on rollbacks.) But still, after handling that, the current error is:

PS D:\blueprints> php blueprint_compiling.php
 [=======>--------------------]  26/100 -- Installing SQLite integration pluginPHP Fatal error:  Uncaught WordPress\Blueprints\Runtime\ProcessFailedException: Process `php wp-cli.phar core install "--url=http://localhost:8081" "--
title=Playground Site" --admin_user= --admin_password=admin [email protected]` failed with exit code 1 and the following stderr output:
Error: PDO Driver for SQLite is missing. Your PHP installation appears not to have the right PDO drivers loaded. These are required for this version of WordPress and the type of database you have specified.

@adamziel
Copy link
Collaborator

adamziel commented Mar 5, 2024

Let's scope this PR to one specific error it solves, not "getting the entire workflow to run". The smaller the changes, the easier to review and discuss they are.

@reimic reimic marked this pull request as ready for review March 5, 2024 13:39
@adamziel adamziel merged commit 4f3104c into WordPress:trunk Mar 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants