Async HTTP Client PHP 7.0 fixes: Non-blocking mode after SSL handshake, recomputing the stream key #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e, recomputing the stream key
Makes the AsyncHTTPClient usable in PHP 7.0 with two changes:
In PHP <= 7.1 and later, making the socket non-blocking before the
SSL handshake makes the stream_socket_enable_crypto() call always return
false. Therefore, we only make the socket non-blocking after the
SSL handshake.
In PHP <= 7.1, stream_select doesn't preserve the keys of the array:
```php
stream_select( $read, $write, $except, 0, $timeout_microseconds );
// If $read is array( 1=> $fp ) before the stream_select() call,
// it will be array( 0 => $fp ) after.
foreach ( $read as $k => $stream ) {
$chunks[ $k ] = fread( $stream, $length );
}
```
Therefore, we recompute the key using array_search() on these older
PHP versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #79
Makes the AsyncHTTPClient usable in PHP 7.0 with two changes:
In PHP <= 7.1 and later, making the socket non-blocking before the SSL handshake makes the stream_socket_enable_crypto() call always return false. Therefore, we only make the socket non-blocking after the SSL handshake.
In PHP <= 7.1, stream_select doesn't preserve the keys of the array:
Therefore, we recompute the key using array_search() on these older PHP versions.