Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Library: Show the scrollbar bottom edge #57482

Conversation

HrithikDalal
Copy link
Contributor

What?

Display/Unhide the Scrollbar Bottom Edge of the Font Library Modal in the Editor.

Why?

Reference Issue - #54401

How?

The bottom edge of the scrollbar inside the modal was obscured due to an absolutely positioned div overlapping it. This was particularly problematic because the width of the scrollbar can vary between different browsers and screen sizes.

To resolve this issue, I implemented a dynamic approach to adjust the width of the overlapping div based on the actual scrollbar width. This was necessary because of the variability in scrollbar sizes across different environments.

Testing Instructions

Appearance -> Editor -> Styles -> Edit Styles -> Typography -> Manage Fonts

Screenshots or screencast

Before
image

After
image

@jordesign jordesign added [Type] Bug An existing feature does not function as intended [Feature] Typography Font and typography-related issues and PRs labels Jan 11, 2024
@t-hamano
Copy link
Contributor

Hi @HrithikDalal,

Sorry for the late review. It seems that this issue has been resolved in #60641.

I would like to close this PR, but I appreciate your efforts.

image

@t-hamano t-hamano closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Font Library [Feature] Typography Font and typography-related issues and PRs [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants