Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List View: focus style is cut off in the Site Editor #69189

Open
2 of 6 tasks
afercia opened this issue Feb 13, 2025 · 1 comment · May be fixed by #69201
Open
2 of 6 tasks

List View: focus style is cut off in the Site Editor #69189

afercia opened this issue Feb 13, 2025 · 1 comment · May be fixed by #69201
Assignees
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Package] Block editor /packages/block-editor [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Feb 13, 2025

Description

In the List View, the focus style looks different between Post editor and Site editor. In the Site editor, it may be cut-off.
To my understanding there's two CSS issues:

1
Each row is made of two table cells <td> elements. In the Site editor, the second cell may not have a dropdown menu toggle button and the cell is empty. Thw width of the cell needs to be 28 pixels even when it's empty.

2
Even after the width issue is fixed, the focus style of the templates (the one that uses the purple 'synced' color) looks different. The whole outline is larger. This is because the box-shadow for template items is different and uses two box-shadowss, with some offset. Not sure why but I would say the shape of the box-shadow should be the same for all items.

In the image below I highlighted all the items in the list view with the focus style, to better illustrate:

  • First screenshot: Post editor: everything looks as expected.
  • Second screenshot: the outline is too wide and it's cut-off on the right.
  • Third screenshot: after fixing the width, the outline of the templages is still too wide.

Image

Step-by-step reproduction instructions

  • Compare the list view in the post editor and site editor.
  • Select the items in the list view so that they show the focus style outline (double click or navigate with keyboard).
  • In the site editor, select also the template items.
  • Observe the outline inconsistencies.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes

Please confirm which theme type you used for testing.

  • Block
  • Classic
  • Hybrid (e.g. classic with theme.json)
  • Not sure
@afercia afercia added [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Package] Block editor /packages/block-editor [Type] Bug An existing feature does not function as intended labels Feb 13, 2025
@t-hamano t-hamano self-assigned this Feb 14, 2025
@t-hamano
Copy link
Contributor

I found the cause of the problem, I'll submit a PR.

@t-hamano t-hamano linked a pull request Feb 14, 2025 that will close this issue
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Package] Block editor /packages/block-editor [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants