Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version numbers from WPEngine's ACF plugin mixed into SCF plugin #6

Open
j-hoffmann opened this issue Nov 28, 2024 · 1 comment
Open

Comments

@j-hoffmann
Copy link

Some @since phpdoc tags use 6.3.8 as version string. The takover form ACF happened after version 6.3.6 when it was turned into SCF. But SCF never had a version 6.3.8. This got mixed up in the messy takeover which led to code being copied from WP Engine's ACF release (in version 6.3.8) but released in SCF with different version number.

Affected code parts:
/includes/post-types/class-acf-taxonomy.php#L510
/includes/post-types/class-acf-post-type.php#L625

@kraftbj
Copy link
Collaborator

kraftbj commented Dec 9, 2024

Thanks. I think it would make the most sense to split the old since tags off, e.g. @since ACF x.x.x vs @since SCF x.x.x too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants