Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom admin header spacing modifications. #665

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

StevenDufresne
Copy link
Contributor

@StevenDufresne StevenDufresne commented Oct 28, 2024

As suggested by @ryelle in WordPress/wordcamp.org#1410 (comment), this PR removes custom CSS styles that were added when the WordPress.org header was sticky.

This fixes issues on WordCamp sites where the Admin bar is positioned on top of the site's header.

Example

Before After
Screenshot 2024-10-28 at 1 19 30 PM Screenshot 2024-10-28 at 1 19 14 PM

Related: As suggested by @ryelle in WordPress/wordcamp.org#1410.

How to Test

Edit: Apply WordPress/wporg-parent-2021#162 first.

  1. Apply these changes in your sandbox.
  2. Navigate around WordPress.org and WordCamp sites and make sure the spacing between the header and the admin bar is expected. Not overlapping, or has an extra space.

@ryelle
Copy link
Contributor

ryelle commented Oct 30, 2024

It looks like something is still removing the callback on the child-theme sites:

Screen Shot 2024-10-30 at 17 44 52

Screen Shot 2024-10-30 at 17 54 02

@StevenDufresne
Copy link
Contributor Author

Ah, my apologies. I tested this incorrectly. The parent theme is removing the styles.

Opened up a PR WordPress/wporg-parent-2021#162.

ryelle added a commit to WordPress/wporg-news-2021 that referenced this pull request Oct 31, 2024
The CSS referenced here was removed in #431, so this defaults back to allowing wporg-mu-plugins to control the admin bar override. See WordPress/wporg-mu-plugins#665
@ryelle
Copy link
Contributor

ryelle commented Oct 31, 2024

Yeah, testing it is a pain since you need to sync to both wporg and wordcamp. This looks good now in combination with the parent theme change 👍🏻

You mentioned in the issue

It seems like some WordCamp sites have already shipped fixes so whatever we do here, we'll need to reach out to those organizers ahead of time.

I did notice in spot-checking the upcoming camps in November that Nairobi & Larissa will have extra whitespace when this merges. The rest, at least in that group, seemed fine.

@StevenDufresne StevenDufresne merged commit adbb562 into trunk Nov 13, 2024
2 checks passed
@StevenDufresne StevenDufresne deleted the fix/remove-header-bump branch November 13, 2024 04:14
ryelle added a commit that referenced this pull request Nov 25, 2024
This value is used elsewhere in the Local Navigation Bar CSS, and in the parent theme. Removing it causes alignment issues when the value is undefined.

Follow-up to #665
Fixes #672
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants