Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate signatureDocumentation #87

Closed
wants to merge 8 commits into from

Conversation

matthewnitschke-wk
Copy link
Contributor

@matthewnitschke-wk matthewnitschke-wk commented Aug 28, 2023

closes #85

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generated file change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generated file change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generated file change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy and paste update from scip's official protobuf file: https://github.com/sourcegraph/scip/blob/main/scip.proto

pubspec.lock Outdated
version: "5.13.0"
version: "5.6.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like dependabot dart is doing some strange things

analyzer v5.13.0 requires dart 2.19.0, and dependabot happily bumped to that version: #75

But, as can be seen from the pubspec.yaml, the min dart version is still set to ">=2.18.0 <3.0.0", implying dependabot is ignoring this specification

This means that when dependabot directly changes just the pubspec.lock file, its bumping the lockfile, but anytime you re-run pub get from the codebase, pub will correctly adjust the version used

@@ -1,6 +1,7 @@
version: 2
updates:
- package-ecosystem: "pub"
- package-ecosystem: pub
versioning-strategy: increase
Copy link
Contributor Author

@matthewnitschke-wk matthewnitschke-wk Aug 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of an unrelated change, but dependabot's default setting is widen for pub

This basically means: "probably dont change the pubspec.yaml file"

We dont want this, always change the pubspec.yaml file to enforce that latest versions of pubspec files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update indexer to populate signature_documentation
3 participants