Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many English language strings NOT available in AMOS for translation #806

Open
germanvaleroelizondo opened this issue Jan 18, 2025 · 1 comment

Comments

@germanvaleroelizondo
Copy link
Contributor

germanvaleroelizondo commented Jan 18, 2025

Many English language strings are not available in AMOS
I translated all the available English language strings in AMOS into Mexican Spanish.
You can check translation stats at https://moodle.org/plugins/mod_booking/translations.

Versions uses
Moodle version: 4.5.1
Boooking version: 8.9.16 (2025011702)

To Reproduce
Steps to reproduce the behavior:

  1. Go to ''Site administration > Language > Language packs >Available language packs
  2. Click on '....'
  3. Scroll down to 'Spanish Mexico'
  4. Install selected language pack
  5. Go to Your profile >Language
  6. Click on Mexican Spanish
  7. Go to "Administración del sitio > Plugins > Reservación > General settings"

All strings SHOULD now be in Spanish
All strings used by this plugin should be in Spanish
BUT many are in English
AND these strings are not available in AMOS for translation

Screenshots
Screenshot in following comment.

Additional context
I found it odd that in GitHub some strings are declared with "double quotes"
I think all strings should be within 'single quotes'
BUT I am not a programmer. I am only a translator.

And I think I saw one string variable that had a '. which look like a CONCATENATION, which is forbidden.

$string['recommendedin'] = "Shortcode to show a list of booking options which should be recommended in a given course.
To use this, add a booking customfield with the shortname 'recommendedin' and comma separated values with the shortnames
of the courses you want to show this recommendations. So: When you want recommend option1 to the participants enroled in
Course 1 (course1), then you need to set the customfield 'recommendedin' from within the booking option to 'course1'.";

PLEASE change string variables with double quotes into single quotes, update code in Moodle plugins database and check whether AMOS now recognizes more strings and marks Booking plugin as NOT 100% TRANSLATED for the Mexican Spanish language pack. If so, send me a Moodle message and I will quickly translate missing strings into mexican Spanish.

Thanks in advance,
Germán

@germanvaleroelizondo
Copy link
Contributor Author

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant