Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding plugin by name (pluginInstall) results in "NOTONBUKKITDEV" #30

Open
bugler opened this issue Oct 17, 2013 · 0 comments
Open

Adding plugin by name (pluginInstall) results in "NOTONBUKKITDEV" #30

bugler opened this issue Oct 17, 2013 · 0 comments

Comments

@bugler
Copy link

bugler commented Oct 17, 2013

SpaceBukkit manager (PHP) correctly calls SpaceBukkit server (java) with pluginName.

This appears to trigger code at:
https://github.com/SpaceDev/SpaceRTK/blob/master/src/me/neatmonster/spacertk/actions/PluginActions.java
Around line 171 ( pluginsManager.getPlugin(pluginName) )

pluginsManager.getPlugin(pluginName) will always return false if the plugin is not already managed -- triggering "NOTONBUKKITDEV". This seems to be a mistake, since if it's not yet installed, it shouldn't be managed.

Unless I misunderstand this, the issue seems to be in:
https://github.com/SpaceDev/SpaceRTK/blob/master/src/me/neatmonster/spacertk/plugins/PluginsManager.java
Around line 107 ( if (contains(pluginName)) { )

Here, it looks like if we manage the plugin, then we'll add it. Shouldn't it be the opposite? This seems to make it impossible to install a plugin using the BukGet UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant