Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple restrict_impl for threshold and scaling #1074

Closed
Giuseppe5 opened this issue Oct 25, 2024 · 0 comments · Fixed by #1071
Closed

Decouple restrict_impl for threshold and scaling #1074

Giuseppe5 opened this issue Oct 25, 2024 · 0 comments · Fixed by #1071
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Giuseppe5
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Currently, we use the same restrict implementation for the scale coming from the stats/parameters/constant, and the threshold.
There might be cases where we want to decouple this.
E.g., in MX the threshold implementation assumes floor as rounding method during po2 computation, however there is no constraints on the restrict impl of the scale, and it can be decoupled.

Describe the solution you'd like
We could have two complete separate implementations with different keywords, as to avoid name clash during dependency injection.

Describe alternatives you've considered
Alternatively, following a similar structure of MSE, we could use SubInjector in dependencies to instantiate the same class twice, once for the threshold and once for the scale.

Additional context
More tests might be needed after this feature.
Dealing with dependencies and SubInjectors requires a bit of expertise.

@Giuseppe5 Giuseppe5 added enhancement New feature or request good first issue Good for newcomers labels Oct 25, 2024
@Giuseppe5 Giuseppe5 linked a pull request Oct 28, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant