Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily disabled -Werror=sign-compare in CMakeLists.txt #2013

Open
erwei-xilinx opened this issue Jan 10, 2025 · 0 comments
Open

Temporarily disabled -Werror=sign-compare in CMakeLists.txt #2013

erwei-xilinx opened this issue Jan 10, 2025 · 0 comments
Assignees
@erwei-xilinx

Comments

@erwei-xilinx
Copy link
Collaborator

mlir-aie/CMakeLists.txt

Line 191 in 1b059e4

# add_flag_if_supported("-Werror=sign-compare" WERROR_SIGN_COMPARE)

Disabled due to nanobind version 2.4 src/nb_func.cpp comparing variables of different types. This has been fixed in nanobind but not yet released (https://github.com/wjakob/nanobind/blob/9ae3ebdf4c4aa19f8d81cd6c8f2d07653412acce/src/nb_func.cpp#L448). The current llvm version requires nanobind 2.4.

Will change CMakeLists.txt back once (1) updated nanobind is released, and (2) llvm is updated to support the newer nanobind releases.
@erwei-xilinx erwei-xilinx self-assigned this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erwei-xilinx erwei-xilinx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erwei-xilinx