Weird player card hand

[Rubylium]

After playing a bit, i found out that sometime the player hand is very strange, for exemple i play one round and everything is fine, and the second round after having 2 card it will say that my hand is 54.
Maybe it could be the player hand not being reset correctly ? Not sure about that, i didn't found a way to repro it at 100% but the glitch do occure pretty often.

( Using the version from 2 day ago, didn't update with the latest commit, tell me if you fixed this issue already and i'm just missing it with the latest commit )

[Xinerki]

This happens when you split your hand. When you do so, the hand value display just combines both hands into one and displays the total. It's not a bug, rather a missing feature.

[Rubylium]

I think I didn't explain well the issue ^^ The "bug" happen on a brand new game, not on the same game. I do a first game, everything works fine. And when I start an other one, I get my 2 first card and the hand that will be display will, sometime be bigger than what I really have. Le ven. 28 févr. 2020 à 01:06, Xin <[email protected]> a écrit :

…

This happens when you split your hand. When you do so, the hand value display just combines both hands into one and displays the total. It's not a bug, rather a missing feature. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#10?email_source=notifications&email_token=AEWODTFCD4CGBBBSQYPASPTRFBIRPA5CNFSM4K5DV3U2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENGOCRA#issuecomment-592240964>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEWODTELOW4W5XQGLO6XOMDRFBIRPANCNFSM4K5DV3UQ> .

[Xinerki]

Oh that's weird. That shouldn't really happen, and I can't think of why it would. I don't remember getting that issue myself so that's odd.

[Rubylium]

Will try to find a repo, but that wasn't really hard to repo it. I remember will doing my test having this issue 2 times Le ven. 28 févr. 2020 à 01:10, Xin <[email protected]> a écrit :

…

Oh that's weird. That shouldn't really happen, and I can't think of why it would. I don't remember getting that issue myself so that's odd. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#10?email_source=notifications&email_token=AEWODTG4KOBMBQ64U4OGRLLRFBJAPA5CNFSM4K5DV3U2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENGOMPY#issuecomment-592242239>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEWODTHSLUYPCGLIDCFRVC3RFBJAPANCNFSM4K5DV3UQ> .

[Xinerki]

alright find a repro and I'll look into it (or frazzle)

[FrazzIe]

i think i have experienced this and i think its just a visual bug and something isn't being reset on a round end?

[Rubylium]

Got a repo !

You need 2 player and 2 table. Just play normaly, 2 players on diffrent table and the visual bug will be here :)

i think i have experienced this and i think its just a visual bug and something isn't being reset on a round end?

Yes, it's just an visual bug, it display for exemple 54 but on server side your hand is the "real" one if i can say it like this ^^

[Xinerki]

I think I know the cause: clientside checks what seat you're in but not what table, so if some player sits at the same seat on another table, clientside hand calculation gets wonky.

[Xinerki]

Commit ecc09b3 should be a fix for this issue, go ahead and test it.

[Rubylium]

Mmh after few days of testing with my players the issue sems to come back sometimes.
Also my players reported that sometime their is some weird bug like they are suppose to loose but the table glitch out and eveyrone win. But i know that will not help you, i will look into those issue to find a repo