Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Challenge in hex breaks keycloak authentication #370

Open
floriansipp opened this issue Feb 28, 2025 · 0 comments
Open

Challenge in hex breaks keycloak authentication #370

floriansipp opened this issue Feb 28, 2025 · 0 comments

Comments

@floriansipp
Copy link

Hello,

This commit breaks keycloak authentication since the challenge is now send in hex and we get this error :

2025-02-28 07:59:06,526 check(b'\x02\x07\x07\x00\r\x08SW\x03\x05\x0cT\x01 … 53144a')
2025-02-28 07:59:06,526 Error: keycloak authentication failed
2025-02-28 07:59:06,526  invalid response received from authorization endpoint
2025-02-28 07:59:06,526 failed to parse json: b'\x02\x07\x07\x00\r\x08SW\x03\x05\x0cT\x01\x00QY …. 5a000606505353144a'
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/xpra/server/auth/keycloak.py", line 88, in check
    response = json.loads(response_json)
  File "/usr/lib/python3.10/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python3.10/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python3.10/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

I suppose we should decode the hex on the other side, but can you point to a function for that ?

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant