[Refactor/#369] 이메일 발신자 설정 (#370)

* refactor: 이메일 발신자 설정 * chore: 파라미터 오타 수정 form -> from
YAPP-Github · Aug 28, 2024 · 699e8b0 · 699e8b0
1 parent ca25f1c
commit 699e8b0
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/email/src/main/kotlin/com/few/email/sender/EmailSender.kt b/email/src/main/kotlin/com/few/email/sender/EmailSender.kt
@@ -14,7 +14,7 @@ abstract class EmailSender<T : SendMailArgs<*, *>>(
         val to = args.to
         val subject = args.subject
         val message = getHtml(args)
-        emailSendProvider.sendEmail(from, to, subject, message)
+        emailSendProvider.sendEmail("FEW Letter <$from>", to, subject, message)
     }
 
     abstract fun getHtml(args: T): String

diff --git a/email/src/main/kotlin/com/few/email/sender/provider/AwsSESEmailSendProvider.kt b/email/src/main/kotlin/com/few/email/sender/provider/AwsSESEmailSendProvider.kt
@@ -19,14 +19,14 @@ class AwsSESEmailSendProvider(
         private const val UTF_8 = "utf-8"
     }
 
-    override fun sendEmail(form: String, to: String, subject: String, message: String) {
+    override fun sendEmail(from: String, to: String, subject: String, message: String) {
         val destination = Destination().withToAddresses(to)
         val sendMessage = Message()
             .withSubject(Content().withCharset(UTF_8).withData(subject))
             .withBody(Body().withHtml(Content().withCharset(UTF_8).withData(message)))
 
         val sendEmailRequest = SendEmailRequest()
-            .withSource(form)
+            .withSource(from)
             .withDestination(destination)
             .withMessage(sendMessage)
             .withConfigurationSetName("few-configuration-set")
@@ -41,7 +41,7 @@ class AwsSESEmailSendProvider(
                 log.info {
                     "Sending email using JavaMailSender."
                 }
-                javaEmailSendProvider.sendEmail(form, to, subject, message)
+                javaEmailSendProvider.sendEmail(from, to, subject, message)
             }.onFailure {
                 log.error {
                     "Failed to send email using JavaMailSender."

diff --git a/email/src/main/kotlin/com/few/email/sender/provider/EmailSendProvider.kt b/email/src/main/kotlin/com/few/email/sender/provider/EmailSendProvider.kt
@@ -1,5 +1,5 @@
 package com.few.email.sender.provider
 
 interface EmailSendProvider {
-    fun sendEmail(form: String, to: String, subject: String, message: String)
+    fun sendEmail(from: String, to: String, subject: String, message: String)
 }
diff --git a/email/src/main/kotlin/com/few/email/sender/provider/JavaEmailSendProvider.kt b/email/src/main/kotlin/com/few/email/sender/provider/JavaEmailSendProvider.kt
@@ -13,11 +13,11 @@ class JavaEmailSendProvider(
     companion object {
         private const val UTF_8 = "utf-8"
     }
-    override fun sendEmail(form: String, to: String, subject: String, message: String) {
+    override fun sendEmail(from: String, to: String, subject: String, message: String) {
         val sendMessage: MimeMessage = emailSender.createMimeMessage()
         val helper = MimeMessageHelper(sendMessage, UTF_8)
         try {
-            helper.setFrom(form)
+            helper.setFrom(from)
             helper.setTo(to)
             helper.setSubject(subject)
             helper.setText(message, true)