-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 이메일 전송 모듈 구성 및 Sender 구현 #67
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
config
설정 파일과 관련된 내용을 다룰 때 사용됩니다
feature
새로운 기능을 만들 때 사용됩니다
labels
Jun 21, 2024
belljun3395
force-pushed
the
feat/#66_belljun3395
branch
from
June 22, 2024 10:26
88f99a5
to
62732b8
Compare
belljun3395
force-pushed
the
feat/#66_belljun3395
branch
from
June 22, 2024 10:29
62732b8
to
6e974f6
Compare
hun-ca
reviewed
Jun 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이메일쪽은 디코 라이브로 코드리뷰 했으면 좋겠는데 어떠신가요?
언제 시간 괜찮으신가요??? |
hun-ca
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 연관 이슈
resolved: #66
💁♂️ PR 내용
🙏 작업
🙈 PR 참고 사항
이메일 관련 테스트를 진행할 예정인데
아래 영상에서 나오는 Mailtrap이라는 서비스 사용해볼까 합니다.
해당 서비스 계정은 공유 구글 계정입니다.
https://www.youtube.com/watch?v=ma6TmOJHVqk
와 같이 수정하고
MailProperties 설정을 612675f 와 같이 수정해서 해결은 했는데
불만족...ㅠㅠ
📸 스크린샷
🤖 테스트 체크리스트