New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter loading outdated #30

Open

flochre wants to merge 4 commits into YDLIDAR:master from flochre:params-rebase

flochre commented Oct 28, 2023

I reused #19 and rebased it
So the commit are still from chenjunnn

added the parameters that were left over

chenjunnn and others added 4 commits

July 9, 2022 17:52


          Declare params using api with default value

a85520a


          Fix some type errors

2c3a38e


          Merge remote-tracking branch 'chenjunnn/params'

88633da


          update last parameter after rebase from chenjunnn

dfac218

flochre mentioned this pull request

Not working with Humble or later #33

Open

Author

flochre commented Oct 28, 2023

This would partly solve #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet