Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Add logo image and publisher name #16

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Conversation

fliklab
Copy link
Contributor

@fliklab fliklab commented Apr 29, 2024

Closes [issue link]

Decsription

  • 로고 이미지 파일 추가 및 package.json애 추가
  • package.json에 publisher name 추가
  • package.json의 잘못된 description 수정(you only code once => you only copy once)
  • readme.md에 로고 이미지 추가

ETC

체크 리스트 (아래 사항들이 전부 체크되어야만 merge)

  • 필요한 테스트를 완료하였고, 기능이 제대로 실행되는지 확인 하였습니다.
  • 코드 스타일 가이드에 맞추어 코드를 작성 하였습니다.
  • 제가 의도한 파일들과 수정 사항들만 커밋이 된 것을 확인 하였습니다.
  • 본 수정 사항들을 팀원들과 사전에 상의하였고 팀원들 모두 해당 PR에 대하여 알고 있습니다.

@fliklab fliklab requested review from givvemee and glassk as code owners April 29, 2024 01:49
Copy link
Member

@glassk glassk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fliklab fliklab requested a review from glassk April 30, 2024 06:32
@fliklab fliklab merged commit 3d13863 into dev Apr 30, 2024
2 checks passed
@fliklab fliklab deleted the chore/add-logo-image branch April 30, 2024 06:35
@givvemee givvemee added the enhancement New feature or request label May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants