Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make this official plugin at https://github.com/asdf-vm/asdf-plugins (Question) #3

Closed
wataruian opened this issue Oct 14, 2023 · 5 comments

Comments

@wataruian
Copy link

Hi @YR-ZR0

I can't find any asdf plugin besides your repo; none is listed officially for earthly at https://github.com/asdf-vm/asdf-plugins too.

Is it possible to submit your asdf plugin at https://github.com/asdf-vm/asdf-plugins and make it official?

I'm not sure what are the criteria for being "official" and being included in the list. But I think it would be great if your plugin is on the list so that others who are searching for the earthly plugin can simply take a look at https://github.com/asdf-vm/asdf-plugins repo.

I hope this makes sense.

Thanks!

@YR-ZR0
Copy link
Owner

YR-ZR0 commented Dec 18, 2023

Hey @wataruian, absolutley, i looked into that this evening and currently just dealing with a ci failure as it doesn't seem to be picking up the license file but after the test passes i've forked the plugin repo and made a folder for the earthly command. Just have the change to the table.

@wataruian
Copy link
Author

Thanks for this @YR-ZR0!

@YR-ZR0
Copy link
Owner

YR-ZR0 commented Dec 19, 2023

it's in as PR asdf-vm/asdf-plugins#934

@YR-ZR0
Copy link
Owner

YR-ZR0 commented Jan 11, 2024

Hey @wataruian that PR above has been merged so it's now live 🎉

@wataruian
Copy link
Author

Awesome! Thanks @YR-ZR0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants