Don't cancel MouseScrolled.Post

It's no longer cancellable, and you can't cancel it in Fabric either.
YaLTeR · Jul 12, 2022 · 2fe9b08 · 2fe9b08
1 parent 2c10082
commit 2fe9b08
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/main/java/yalter/mousetweaks/Main.java b/src/main/java/yalter/mousetweaks/Main.java
@@ -302,7 +302,7 @@ public static boolean onMouseDrag(Screen screen, double x, double y, MouseButton
      * @param x           Mouse X.
      * @param y           Mouse Y.
      * @param scrollDelta The scroll delta.
-     * @return True if the event was handled and should be cancelled.
+     * @return True if the event was handled by Mouse Tweaks.
      */
     public static boolean onMouseScrolled(Screen screen, double x, double y, double scrollDelta) {
         updateScreen(screen);

diff --git a/src/main/java/yalter/mousetweaks/forge/MouseTweaksForge.java b/src/main/java/yalter/mousetweaks/forge/MouseTweaksForge.java
@@ -61,8 +61,8 @@ public void onGuiMouseScrollPost(MouseScrolled.Post event) {
         // than one with a bigger delta.
         Logger.DebugLog("onGuiMouseScrollPost delta = " + event.getScrollDelta());
 
-        if (Main.onMouseScrolled(event.getScreen(), event.getMouseX(), event.getMouseY(), event.getScrollDelta()))
-            event.setCanceled(true);
+        // Post events aren't cancellable, but that's okay.
+        Main.onMouseScrolled(event.getScreen(), event.getMouseX(), event.getMouseY(), event.getScrollDelta());
     }
 
     @SubscribeEvent