Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMNetModel cannot be load #75

Open
ismu opened this issue Sep 4, 2021 · 5 comments
Open

HMNetModel cannot be load #75

ismu opened this issue Sep 4, 2021 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@ismu
Copy link

ismu commented Sep 4, 2021

Hi :)

I have problem with HMNetModel. I can't load it on yours Colab notebook.
I prepare code for this task:

from model import HMNetModel

hmn = HMNetModel()

I get error:

usage: ipykernel_launcher.py [-h] [--command COMMAND] [--conf_file CONF_FILE]
                             [--PYLEARN_MODEL PYLEARN_MODEL]
                             [--master_port MASTER_PORT] [--cluster CLUSTER]
                             [--dist_init_path DIST_INIT_PATH] [--fp16]
                             [--fp16_opt_level FP16_OPT_LEVEL] [--no_cuda]
                             [--config_overrides CONFIG_OVERRIDES]
ipykernel_launcher.py: error: unrecognized arguments: -f /root/.local/share/jupyter/runtime/kernel-d260cea4-6d66-4567-bbda-0e4a0fefba13.json
An exception has occurred, use %tb to see the full traceback.

SystemExit: 2

Do you know what's happen? Thanks in advance for your help :)

@niansong1996 niansong1996 added the bug Something isn't working label Sep 4, 2021
@ismu
Copy link
Author

ismu commented Sep 4, 2021

I investigate a bit this problem. It doesn't seem to work just for the colab. When I install SummerTime locally, model is loaded.

@niansong1996
Copy link
Collaborator

Can you try now since #79 is just merged to solve some issues for HMNet?

@ismu
Copy link
Author

ismu commented Sep 12, 2021

Yes I test your code and it seems all work from running point of view. One problem is that, the HMNetModel isn't downloading automatically, I had to do it manually - related with #84?
The second problem is I think poor quality of the results from the model. I don't know it is problem with model or with preprocessing of input to model. In official publication the example looks better. I try investigate this a bit :)

EDIT:
I see you change model in yours pull request. What is the difference between these models? The AMI finetuned model seems to work better.

@niansong1996
Copy link
Collaborator

niansong1996 commented Sep 13, 2021

#84 is more related to the dataset caching, not models per se. For HMNet, after #79, it should be downloading automatically for the first time, if it hasn't been cached before.

I believe the AMI model is fine-tuned on AMI dialogue data and the new one is pre-trained on a "dialogue-ized" CNN/DM data. I found the latter one to be working better in my case, hence the change. But it should be easy enough to provide options to the users, I'll be on that soon.

@ismu
Copy link
Author

ismu commented Sep 13, 2021

Yes, I think the option to choose a model would be good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants