Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rationalize testing #6

Open
Ybalrid opened this issue Sep 29, 2019 · 2 comments
Open

Rationalize testing #6

Ybalrid opened this issue Sep 29, 2019 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@Ybalrid
Copy link
Owner

Ybalrid commented Sep 29, 2019

Currently the CI is only there to check the syntax of the header code.

There are a few odd test programs in /tests/, but nothing really useful.

New test should be written using Catch2
@Ybalrid Ybalrid added the help wanted Extra attention is needed label Sep 29, 2019
@scivision
Copy link
Contributor

This is a good idea. I would propose having
CMake FetchContent Catch2
rather than vendoring or Git Submodule, to avoid cluttering kissnet Git history.
Specifically, if the user has set kissnet_BUILD_TESTING=true, then Catch2 will be downloaded, built and run the unit tests.
Meson can effectively do the same thing, downloading and building Catch2 when tests are requested.

@scivision
Copy link
Contributor

Another thought is Catch2 is preparing a v3 release. The API has some changes, so maybe it's worth waiting for Catch2 v3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ybalrid @scivision