From 5a7281b4457b66499a053961d23b4a7da3f1394f Mon Sep 17 00:00:00 2001 From: StiefelJackal Date: Tue, 19 Nov 2024 22:18:00 -0500 Subject: [PATCH 1/4] fix(accessibility): adjust incorrect heading order --- public/stylesheets/style.css | 4 ++++ views/session.pug | 2 +- views/world.pug | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/public/stylesheets/style.css b/public/stylesheets/style.css index f650c1b..b323ec8 100644 --- a/public/stylesheets/style.css +++ b/public/stylesheets/style.css @@ -2,6 +2,10 @@ --background-body: #11151d; } +.subheading { + font-size: 1rem; +} + .center { display: flex; flex-wrap: wrap; diff --git a/views/session.pug b/views/session.pug index f6c6732..91f9db3 100644 --- a/views/session.pug +++ b/views/session.pug @@ -24,7 +24,7 @@ block content p.center a(href="https://wiki.resonite.com/go.resonite.com") Need Help? - h4 Alternative URLs + h2.subheading Alternative URLs ul li #[strong Session Url:] #{`ressession:///${sessionId}`} li #[strong Connection Urls:] diff --git a/views/world.pug b/views/world.pug index ca032b3..c07bee9 100644 --- a/views/world.pug +++ b/views/world.pug @@ -22,6 +22,6 @@ block content a.btn(href=`resrec:///${ownerId}/${id}`) Open World! p.center a(href="https://wiki.resonite.com/go.resonite.com") Need Help? - h4 Alternative URLs + h2.subheading Alternative URLs ul li #[strong Record Url:] #{`resrec:///${ownerId}/${id}`} \ No newline at end of file From ffc8ccfb876bd8b6b320bc01d906ba120f446b8f Mon Sep 17 00:00:00 2001 From: StiefelJackal Date: Tue, 19 Nov 2024 22:18:36 -0500 Subject: [PATCH 2/4] fix(accessibility): add missing alt text for images --- views/layout.pug | 2 +- views/session.pug | 2 +- views/world.pug | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/views/layout.pug b/views/layout.pug index ea908d1..9126d16 100644 --- a/views/layout.pug +++ b/views/layout.pug @@ -15,7 +15,7 @@ html(lang="en") @import url('https://fonts.googleapis.com/css2?family=Poppins:ital,wght@0,100;0,200;0,300;0,400;0,500;0,600;0,700;0,800;0,900;1,100;1,200;1,300;1,400;1,500;1,600;1,700;1,800;1,900&display=swap'); header.center - img(src='/images/resonite.png') + img(src='/images/resonite.png' alt='Resonite') body block content h1 Placeholder diff --git a/views/session.pug b/views/session.pug index 91f9db3..6098305 100644 --- a/views/session.pug +++ b/views/session.pug @@ -13,7 +13,7 @@ block content h1 !{name} .center - img(src=thumbnailUrl) + img(src=thumbnailUrl alt=`A preview image of the '${title}' session.`) ul li #[strong Host:] #{hostUsername} diff --git a/views/world.pug b/views/world.pug index c07bee9..ae35272 100644 --- a/views/world.pug +++ b/views/world.pug @@ -12,7 +12,7 @@ block content h1 !{name} .center - img(src=thumbnailUri) + img(src=thumbnailUri alt=`A preview image of the '${title}' world.`) ul li #[strong By:] #{ownerName} From 9394f0136c0f5b28068ce3b8b295cd96690b0494 Mon Sep 17 00:00:00 2001 From: StiefelJackal Date: Tue, 19 Nov 2024 22:19:01 -0500 Subject: [PATCH 3/4] fix(accessibility): add missing title for index page --- routes/index.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/routes/index.js b/routes/index.js index a9a193d..dbb8908 100644 --- a/routes/index.js +++ b/routes/index.js @@ -7,7 +7,9 @@ var router = express.Router(); /* GET home page. */ router.get('/', function(req, res, next) { - res.render('index'); + res.render('index', { + title: 'go.resonite.com Home' + }); }); router.get('/session/:sessionId', (req,res, next) => handle("session", req, res, next)); @@ -42,7 +44,7 @@ function getUrl(type, req) { /** * Creates an error for the Web response of a failed call to the api. * - * @param {Response} res The response of the api request. + * @param {SessionInfoA} res The response of the api request. * @param {('world'|'session')} type The type of information this is whether it is a world or session. * @returns */ From 8f3243e05afa2f76058fae45c17e3f142d9a51ef Mon Sep 17 00:00:00 2001 From: StiefelJackal Date: Tue, 19 Nov 2024 22:19:20 -0500 Subject: [PATCH 4/4] chore: remove random end space --- views/index.pug | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/views/index.pug b/views/index.pug index e2a0168..b98e566 100644 --- a/views/index.pug +++ b/views/index.pug @@ -1,7 +1,7 @@ extends layout block content - h1 go.resonite.com + h1 go.resonite.com p go.resonite.com is used to link to worlds and sessions from the web. It's home page doesn't have any functionality at the moment. p Would you like to