Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to love recipients explore page after sending love. #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rockdog
Copy link
Member

@rockdog rockdog commented Mar 10, 2017

screenshot 2017-03-10 12 10 11

@@ -0,0 +1,11 @@
# -*- coding: utf-8 -*-
from dominate.tags import a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan on making more use of this in the future, e.g. for manipulating the DOM? It seems overkill to add the library just to generate <a href="...">...</a>.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe. I can‘t say right now.

I just didn‘t feel like building tag(s) myself and re-implementing the wheel. And since this lib seems kind of maintained and has no other dependencies I felt okay adding it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are you reimplementing the wheel?

 a(employee, href=url_for('explore', user=employee)).render()
'<a href="{}">{}</a>'.format(url_for('explore', user=employee), employee)

I'm generally wary of adding these kinds of dependencies, it's just one more thing to maintain that adds bloat to our project. And it's not like a) we expect changes to how a tags are built that this package will cover for us; or b) that we not already have folders full of HTML. I consider this a general feeling of not wanting to put HTML markup in a "code" file, while the library just hides the fact that you do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants