Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove showConsoleProgress flag #92

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

88manpreet
Copy link
Contributor

This flag would show the live progress of a spark job on the console (driver logs).
This is really useful for debugging.
However, as part of tron jobs it is noisy, and not useful to parse for debugging purposes.
This can be added on-demand as part of adhoc jobs.

Copy link
Member

@jsleight jsleight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but need to fix test failures

@88manpreet
Copy link
Contributor Author

Onpoint @cuza can you help me address this error?
Rebasing master also didn't help, neither did creating a new PR.
https://github.com/Yelp/service_configuration_lib/actions/runs/3491738063/jobs/5845566366
fatal: could not read Username for 'https://gitlab.com/': No such device or address

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants