Double click to edit

[s2b-git]

How about changing quick edit mode to double click instead of little pencil?
This could apply to list/related list view too. It will be very helpful in improving performance.

[TonyM15]

It has been touched few times, but seems like developer dont work on large set of data. In the situation where navigation in detail view has been cut off, and where record preview list works very very slow, this will be absolutely helpfull improvement.
Maybe at least some comment? We talking about improving UI+UX not about additional functionality

[ArniSamano]

I would be excellent to have duble click in list and related list view. For for instance leads generation center like I working in it is essential functionality

[apcloic]

Not as straightforward as double click but Occurrences module have a nice feature to edit related Participants status & comment fields from listview using a small modal popup.

[s2b-git]

This is cool. Perfect for every list items. Is it configurable somewhere? Cannot find here

[mariuszkrzaczkowski]

Demo: https://gitdeveloper.yetiforce.com/index.php?module=Occurrences&relatedModule=Contacts&view=Detail&record=1515&mode=showRelatedList&relationId=624&tab_label=LBL_PARTICIPANTS

Doc: https://doc.yetiforce.com/code/classes/Config-Relation.html#property_separateChangeRelationButton

/** Separate change relation button in related module */
public static $separateChangeRelationButton = true;

/** Separate change relation button in related module */
public static $separateChangeRelationButton = false;

[wajihjallal]

Thanks for the reply

[ArniSamano]

Having this button in other (including custom) modules will be pretty significant UX improvement. Can we have shortcut to get it in custom way?

Thanks!

[mariuszkrzaczkowski]

it won't be that simple, this is a new type of relationship

YetiForceCRM/modules/Occurrences/relations/GetRelatedMembers.php

Lines 1 to 131 in 7a0e0be

	<?php
	/**
	* Includes RelatedMembers relation.
	*
	* @package Relation
	*
	* @copyright YetiForce S.A.
	* @license YetiForce Public License 5.0 (licenses/LicenseEN.txt or yetiforce.com)
	* @author Radosław Skrzypczak <[email protected]>
	*/
	/**
	* Class GetRelatedMembers.
	*/
	class Occurrences_GetRelatedMembers_Relation extends Vtiger_GetRelatedList_Relation
	{
	/** {@inheritdoc} */
	public const TABLE_NAME = 'u_#__relations_members_entity';
	/**
	* Field custom list.
	*
	* @var array
	*/
	public $customFields = [
	'status_rel' => [
	'label' => 'LBL_STATUS_REL',
	'uitype' => 16,
	],
	'comment_rel' => [
	'label' => 'LBL_COMMENT_REL',
	'uitype' => 21,
	],
	'rel_created_user' => [
	'label' => 'LBL_RELATION_CREATED_USER',
	'uitype' => 52,
	'displaytype' => 10
	],
	];
	/**
	* Field list.
	*
	* @param bool $editable
	*
	* @return array
	*/
	public function getFields(bool $editable = false)
	{
	$fields = [];
	$sourceModule = $this->relationModel->getParentModuleModel();
	if ('Occurrences' !== $sourceModule->getName()) {
	$sourceModule = $this->relationModel->getRelationModuleModel();
	}
	foreach ($this->customFields as $fieldName => $data) {
	$field = new \Vtiger_Field_Model();
	$field->set('name', $fieldName)->set('column', $fieldName)->set('table', static::TABLE_NAME)->set('fromOutsideList', true)->setModule($sourceModule);
	foreach ($data as $key => $value) {
	$field->set($key, $value);
	}
	if (!$editable || !$field->isEditableReadOnly()) {
	$fields[$fieldName] = $field;
	}
	}
	return $fields;
	}
	/** {@inheritdoc} */
	public function getQuery()
	{
	parent::getQuery();
	$tableName = static::TABLE_NAME;
	$queryGenerator = $this->relationModel->getQueryGenerator();
	foreach (array_keys($this->customFields) as $fieldName) {
	$queryGenerator->setCustomColumn(["{$tableName}.{$fieldName}"]);
	}
	}
	/** {@inheritdoc} */
	public function create(int $sourceRecordId, int $destinationRecordId): bool
	{
	$result = false;
	if (!$this->getRelationData($sourceRecordId, $destinationRecordId)) {
	$result = \App\Db::getInstance()->createCommand()->insert(static::TABLE_NAME, [
	'crmid' => $sourceRecordId,
	'relcrmid' => $destinationRecordId,
	'rel_created_user' => \App\User::getCurrentUserRealId(),
	])->execute();
	}
	return $result;
	}
	/**
	* updateRelationData function.
	*
	* @param int $sourceRecordId
	* @param int $destinationRecordId
	* @param array $updateData
	*
	* @return bool
	*/
	public function updateRelationData(int $sourceRecordId, int $destinationRecordId, array $updateData): bool
	{
	$conditions = [
	'or',
	['crmid' => $sourceRecordId, 'relcrmid' => $destinationRecordId],
	['crmid' => $destinationRecordId, 'relcrmid' => $sourceRecordId],
	];
	$result = (bool) $this->getRelationData($sourceRecordId, $destinationRecordId);
	if ($result) {
	$result = (bool) \App\Db::getInstance()->createCommand()->update(static::TABLE_NAME, $updateData, $conditions)->execute();
	}
	return $result;
	}
	/**
	* Get relation data.
	*
	* @param int $sourceRecordId
	* @param int $destinationRecordId
	*
	* @return array
	*/
	public function getRelationData(int $sourceRecordId, int $destinationRecordId)
	{
	return (new \App\Db\Query())->from(static::TABLE_NAME)->where([
	'or',
	['crmid' => $sourceRecordId, 'relcrmid' => $destinationRecordId],
	['crmid' => $destinationRecordId, 'relcrmid' => $sourceRecordId],
	])->one();
	}
	}

[s2b-git]

it won't be that simple, this is a new type of relationship

YetiForceCRM/modules/Occurrences/relations/GetRelatedMembers.php

Lines 1 to 131 in 7a0e0be

	<?php
	/**
	* Includes RelatedMembers relation.
	*
	* @package Relation
	*
	* @copyright YetiForce S.A.
	* @license YetiForce Public License 5.0 (licenses/LicenseEN.txt or yetiforce.com)
	* @author Radosław Skrzypczak <[email protected]>
	*/
	/**
	* Class GetRelatedMembers.
	*/
	class Occurrences_GetRelatedMembers_Relation extends Vtiger_GetRelatedList_Relation
	{
	/** {@inheritdoc} */
	public const TABLE_NAME = 'u_#__relations_members_entity';
	/**
	* Field custom list.
	*
	* @var array
	*/
	public $customFields = [
	'status_rel' => [
	'label' => 'LBL_STATUS_REL',
	'uitype' => 16,
	],
	'comment_rel' => [
	'label' => 'LBL_COMMENT_REL',
	'uitype' => 21,
	],
	'rel_created_user' => [
	'label' => 'LBL_RELATION_CREATED_USER',
	'uitype' => 52,
	'displaytype' => 10
	],
	];
	/**
	* Field list.
	*
	* @param bool $editable
	*
	* @return array
	*/
	public function getFields(bool $editable = false)
	{
	$fields = [];
	$sourceModule = $this->relationModel->getParentModuleModel();
	if ('Occurrences' !== $sourceModule->getName()) {
	$sourceModule = $this->relationModel->getRelationModuleModel();
	}
	foreach ($this->customFields as $fieldName => $data) {
	$field = new \Vtiger_Field_Model();
	$field->set('name', $fieldName)->set('column', $fieldName)->set('table', static::TABLE_NAME)->set('fromOutsideList', true)->setModule($sourceModule);
	foreach ($data as $key => $value) {
	$field->set($key, $value);
	}
	if (!$editable || !$field->isEditableReadOnly()) {
	$fields[$fieldName] = $field;
	}
	}
	return $fields;
	}
	/** {@inheritdoc} */
	public function getQuery()
	{
	parent::getQuery();
	$tableName = static::TABLE_NAME;
	$queryGenerator = $this->relationModel->getQueryGenerator();
	foreach (array_keys($this->customFields) as $fieldName) {
	$queryGenerator->setCustomColumn(["{$tableName}.{$fieldName}"]);
	}
	}
	/** {@inheritdoc} */
	public function create(int $sourceRecordId, int $destinationRecordId): bool
	{
	$result = false;
	if (!$this->getRelationData($sourceRecordId, $destinationRecordId)) {
	$result = \App\Db::getInstance()->createCommand()->insert(static::TABLE_NAME, [
	'crmid' => $sourceRecordId,
	'relcrmid' => $destinationRecordId,
	'rel_created_user' => \App\User::getCurrentUserRealId(),
	])->execute();
	}
	return $result;
	}
	/**
	* updateRelationData function.
	*
	* @param int $sourceRecordId
	* @param int $destinationRecordId
	* @param array $updateData
	*
	* @return bool
	*/
	public function updateRelationData(int $sourceRecordId, int $destinationRecordId, array $updateData): bool
	{
	$conditions = [
	'or',
	['crmid' => $sourceRecordId, 'relcrmid' => $destinationRecordId],
	['crmid' => $destinationRecordId, 'relcrmid' => $sourceRecordId],
	];
	$result = (bool) $this->getRelationData($sourceRecordId, $destinationRecordId);
	if ($result) {
	$result = (bool) \App\Db::getInstance()->createCommand()->update(static::TABLE_NAME, $updateData, $conditions)->execute();
	}
	return $result;
	}
	/**
	* Get relation data.
	*
	* @param int $sourceRecordId
	* @param int $destinationRecordId
	*
	* @return array
	*/
	public function getRelationData(int $sourceRecordId, int $destinationRecordId)
	{
	return (new \App\Db\Query())->from(static::TABLE_NAME)->where([
	'or',
	['crmid' => $sourceRecordId, 'relcrmid' => $destinationRecordId],
	['crmid' => $destinationRecordId, 'relcrmid' => $sourceRecordId],
	])->one();
	}
	}

How about displaying quick edit as a separate button? I am fighting here for efficiency and literally trying to save microseconds, as data which shall be manually edited is rather large.

[ArniSamano]

So basically adding record to the table and adusting this file to different module sorting out it... or there are other tricks I didnt noticed?
Thanks for tips
BEst

[apcloic]

@ArniSamano

If you only need the same status / comment fields, you could use the same table (u_#__relations_members_entity) so this is quite easy.

1 - Create relation and adjust in /modules/your_custom_module/relations/GetRelatedMembers.php
2- Rename relation in vtiger_relatedlists table and change from getRelatedList to getRelatedMembers
3- Change $separateChangeRelationButton from 'false' to 'true' in /config/Relation.php

Note : options for 'status_rel' field are defined in vtiger_status_rel table.

[ArniSamano]

Clear. Thanks guys

[ArniSamano]

The only thing with above mentioned is that it creates additional data. Pain is that I will have to deal with possibly millions of records so changes should stay in the module itself. Still quick edit button as a separate icon would be cool to have

[s2b-git]

According to initial thread post,,, is there a plan to upgrade UI in near future to be in line with better UX and actual trends?

Best!

[mariuszkrzaczkowski]

Not for the next month, but we're thinking about what to do with it.

[mariuszkrzaczkowski]

Added support for double-clicking in the list of records for quick/full editing 7da0b55 :)

[s2b-git]

This is cool. Thanks Marius. Will you merge with gitdev soon?

[mariuszkrzaczkowski]

I reloaded gitdev and it's there https://gitdeveloper.yetiforce.com/index.php?module=Leads&view=List&mid=48&parent=47

[s2b-git]

Marius, deploying changes directly to last stable does not bring effect. Any additional config is required?

[mariuszkrzaczkowski]

hard to say without verification

[rskrzypczak]

Disable loading min.js files in config/Developer.php ;)
public static $MINIMIZE_JS = false;

[s2b-git]

That was the trick. Respect. This little thing is not that little (for many)
Thanks

[garryatbrighton]

Somehow double-click doesn't work with custom module. What should be done?

Thanks