Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host settings #37

Open
hartois opened this issue Mar 23, 2019 · 3 comments
Open

Host settings #37

hartois opened this issue Mar 23, 2019 · 3 comments

Comments

@hartois
Copy link

hartois commented Mar 23, 2019

In clientsocket.cpp, clientserver.cpp have hardcoded

SERVER = gethostbyname("mailgate.filoxeni.com");

It may be worth replacing them with the use of constants from shared_constants.h ?

@YiannisBourkelis
Copy link
Owner

@hartois better leave it there at the moment mainly for testing purposes to be close to the place we use it. SERVER is not shared across multiple projects. It is used only on a Andama client, not the proxy.
shared_constants.h is the place for constants used by both Andama and AndamaProxy

@hartois
Copy link
Author

hartois commented Mar 26, 2019

@YiannisBourkelis It is not comfortable. When updating the source you need to merge the configuration - this is not correct.

@YiannisBourkelis
Copy link
Owner

@hartois what do you suggest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants