Skip to content
This repository has been archived by the owner on Oct 4, 2022. It is now read-only.

add Dutch no vowel or consonant doubling exception #432

Closed
wants to merge 194 commits into from
Closed

add Dutch no vowel or consonant doubling exception #432

wants to merge 194 commits into from

Conversation

FAMarfuaty
Copy link
Contributor

Summary

This PR can be summarized below:

  • adds exception check for words that does not need to undergo consonant doubling before attaching certain suffixes (i.e. -en, -end, -e, -er, -ere) or to undergo vowel doubling after deleting suffixes in stemming process.

Test instructions

This PR can be tested by following these steps:

  • add more words from noVowelOrConsonantDoubling list in stemming exception to addVerbSuffixesSpec, addNounSuffixesSpec and addAdjectiveSuffixesSpec.
  • take words from noun category to be added to addNounSuffixesSpec, and so forth.
  • add more words from noVowelOrConsonantDoubling list (from any category) in stemming exception to stemSpec.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #416

agnieszkaszuba and others added 30 commits May 28, 2019 17:47
@agnieszkaszuba
Add stem function
68c1d9c
@agnieszkaszuba
Merge branch 'develop' of github.com:Yoast/javascript into stories/29…
3eff7fa 
…8-dutch-stemmer
@agnieszkaszuba
Improve stemming function and add specs
6918a82
@agnieszkaszuba
Remove j from valid -s endings
bf51364
@agnieszkaszuba
Add undoubling of vowel to stemming function
83c1e76
@agnieszkaszuba
Add back mistakingly removed characters from German stemmer
5fc14a0
@agnieszkaszuba
Remove one more character from German stemmer
4bb56f5
@agnieszkaszuba
Merge branch 'develop' of github.com:Yoast/javascript into stories/29…
2b2433d 
…8-dutch-stemmer
@agnieszkaszuba
Add stemming of diminutives
1e5c2f0
@agnieszkaszuba
Stem apostrophe
f4da4de
@agnieszkaszuba
Add more sufixes to stem
0f5c8c8
@agnieszkaszuba
Add adjective stemming
8687bbf
@agnieszkaszuba
Merge branch 'develop' of github.com:Yoast/javascript into stories/29…
f470aa4 
…8-dutch-stemmer
@agnieszkaszuba
Refactor functions that look for suffixes to be deleted
c47572d
@agnieszkaszuba
Improve regexes for detecting suffixes
cd82570
@agnieszkaszuba
Add more tests for Dutch stemmer
1edc980
@agnieszkaszuba
Replace z with s and v with f if at the end of stem
704774f
@agnieszkaszuba
Add vowel doubling functionality
6e4078c
@agnieszkaszuba
Add comparative partitive adjective suffix
2198c69
@agnieszkaszuba
Add more diminutive suffixes
6c6ef94
@agnieszkaszuba
Add comments
d403fd4
@agnieszkaszuba
Add consonant undoubling function
9185c82
@agnieszkaszuba
Add adjective suffixes functionality
b278e99
@agnieszkaszuba
Merge branch 'develop' of github.com:Yoast/javascript into stories/29…
e8af551 
…8-dutch-stemmer
@agnieszkaszuba @nataliashitova
Change 'German' to 'Dutch' in the file description
6614c51 
Co-Authored-By: nataliashitova <[email protected]>
@agnieszkaszuba @nataliashitova
Make comment on determineR1 function more specific
0859ca1 
Co-Authored-By: nataliashitova <[email protected]>
@agnieszkaszuba @nataliashitova
Fix typo
81c6083 
Co-Authored-By: nataliashitova <[email protected]>
Add noun data
0b75a84
Merge branch 'stories/298-dutch-stemmer' of https://github.com/Yoast/…
3543064 
…javascript into stories/298-dutch-stemmer
@agnieszkaszuba
Refactor stemmer
47ba078
Fitria Marfuaty and others added 28 commits December 9, 2019 13:29
Merge branch 'develop' of https://github.com/Yoast/javascript into fe…
005e4e0 
…ature/Dutch-morphology
Merge branch 'develop' of https://github.com/Yoast/javascript into 41…
5be0853 
…6-dutch-noVOwelOrConsonantDoubling-exception
Merge branch 'feature/Dutch-morphology' of https://github.com/Yoast/j…
1d4f463 
…avascript into 416-dutch-noVOwelOrConsonantDoubling-exception
Merge branch 'feature/Dutch-morphology' of https://github.com/Yoast/j…
cc85c99 
…avascript into 416-dutch-noVOwelOrConsonantDoubling-exception
Set premium configuration dependency to default
ef40603
@agnieszkaszuba
Merge branch 'develop' of github.com:Yoast/javascript into feature/Du…
cbde42a 
…tch-morphology
@agnieszkaszuba
Merge branch 'feature/Dutch-morphology' of github.com:Yoast/javascrip…
2c141c5 
…t into feature/Dutch-morphology
@agnieszkaszuba
Merge branch 'feature/Dutch-morphology' of github.com:Yoast/javascrip…
db8e905 
…t into 389-regular-dutch-participles
@agnieszkaszuba
Remove unnecessary function and move a function outside of helpers
219488a
@agnieszkaszuba
Merge branch 'feature/Dutch-morphology' of github.com:Yoast/javascrip…
1364dc4 
…t into 389-regular-dutch-participles
@agnieszkaszuba
Merge branch 'develop' of github.com:Yoast/javascript into feature/Du…
52eef7a 
…tch-morphology
@hansjovis
Added extra tests for Dutch participles.
ebd3203
@hansjovis
Merge pull request #397 from Yoast/389-regular-dutch-participles
8f35325 
Create regular participles in Dutch
@agnieszkaszuba
Merge branch 'feature/Dutch-morphology' of github.com:Yoast/javascrip…
1d2264f 
…t into feature/Dutch-morphology
@agnieszkaszuba
Merge branch 'develop' of github.com:Yoast/javascript into feature/Du…
8357b38 
…tch-morphology
@manuelaugustin
Merge pull request #388 from Yoast/384-stem-dutch-participles
901e333 
Stem regular Dutch participles
Merge branch 'develop' of https://github.com/Yoast/javascript into fe…
85167e0 
…ature/Dutch-morphology
Merge branch 'feature/Dutch-morphology' of https://github.com/Yoast/j…
6b11898 
…avascript into feature/Dutch-morphology
Merge branch 'develop' of https://github.com/Yoast/javascript into fe…
a41b1a4 
…ature/Dutch-morphology
Merge branch 'develop' of https://github.com/Yoast/javascript into 41…
e68b0d0 
…6-dutch-noVOwelOrConsonantDoubling-exception
Merge branch 'feature/Dutch-morphology' of https://github.com/Yoast/j…
79a3faf 
…avascript into 416-dutch-noVOwelOrConsonantDoubling-exception
@agnieszkaszuba
Merge branch 'develop' of github.com:Yoast/javascript into feature/Du…
76b2db8 
…tch-morphology
@agnieszkaszuba
Merge branch 'feature/Dutch-morphology' of github.com:Yoast/javascrip…
435a4ec 
…t into feature/Dutch-morphology
Add check for words that do not need to undergo vowel or consonant do…
12504af 
…ubling process after suffix deletion
Merge branch 'feature/Dutch-morphology' of https://github.com/Yoast/j…
f4ee97c 
…avascript into feature/Dutch-morphology
Merge branch 'feature/Dutch-morphology' of https://github.com/Yoast/j…
34c5a1f 
…avascript into 416-dutch-noVOwelOrConsonantDoubling-exception
Fix name reference
ee28fa9
Merge branch 'feature/Dutch-morphology' of https://github.com/Yoast/j…
fadd54f 
…avascript into 416-dutch-noVOwelOrConsonantDoubling-exception
@FAMarfuaty FAMarfuaty added this to the Dutch morphology milestone Jan 8, 2020
@FAMarfuaty FAMarfuaty closed this Jan 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Dutch morphology
Development

Successfully merging this pull request may close these issues.

no vowel or consonant doubling exception checks
6 participants
@FAMarfuaty @agnieszkaszuba @nataliashitova @hansjovis @manuelaugustin @maartenleenders