Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 2 #9

Closed
wants to merge 9 commits into from
Closed

Patch 2 #9

wants to merge 9 commits into from

Conversation

devops-youlend
Copy link

what

  • Describe high-level what changed as a result of these commits (i.e. in plain-english, what do these changes mean?)
  • Use bullet points to be concise and to the point.

why

  • Provide the justifications for the changes (e.g. business case).
  • Describe why these changes were made (e.g. why do these commits fix the problem?)
  • Use bullet points to be concise and to the point.

references

  • Link to any supporting github issues or helpful documentation to add some context (e.g. stackoverflow).
  • Use closes #123, if this PR closes a GitHub issue #123

Woolersuk and others added 9 commits February 7, 2023 09:58
│ Warning: Argument is deprecated
│
│   with module.amis.module.app_instance.aws_eip.additional,
│   on .terraform/modules/amis.app_instance/eni.tf line 24, in resource "aws_eip" "additional":
│   24:   vpc               = true
│
│ use domain attribute instead
│ Warning: Argument is deprecated
│
│   with module.amis.module.app_instance.aws_eip.default,
│   on .terraform/modules/amis.app_instance/main.tf line 145, in resource "aws_eip" "default":
│  145:   vpc               = true
│
│ use domain attribute instead
│
│ (and 8 more similar warnings elsewhere)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants