-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion on the future of schema generators #295
Comments
@domoritz I think it maybe time to make that call! Following some of the issues here it does seem you may have subconsciously deprecated this module in favour of vega/ts-json-schema-generator. It does make sense to me to reduce redundant effort. It solved my issue and seems to have more support. |
The advantage of this library here is that it is a single file. Yes, I do not have the cycles to maintain this library actively but if someone wants to use it and it works for them as it, it may still be a right tool. Having said that, some things may change over the next few months and I am open to reconsidering my decision later. |
It would be good to point somewhere because there are a lot of pending pull requests and issues. I was about to ask about supporting bigint but I see a lot of people mentioning not supporting Symbol with no answers, and most of the issues don't seem to have any answers either. Is this still active? |
If I'm starting a new project that requires this functionality, should I prefer this library, or would you recommend another one? |
vega/ts-json-schema-generator is a lot better than this one on edge cases. I'm curious why you want to start a new project. Maybe you can help with the new one I linked to. |
I didn't mean a project to replace any of these libraries. I mean a consumer for my own application. So I guess vega/ts-json-schema-generator is what you recommend then, thanks! |
Yes. This repo is in maintenance mode and I personally don't fix anything and only accept prs and make releases. |
FWIW, I am working on a project where I started with this package for schema generation, then moved to EDIT: minimal examples that generates an incorrect schema, in this gist. Does anyone have recent experience with quicktype in comparison? |
quicktype appears to use @mark.probst/typescript-json-schema, which is a mysterious fork of this repo - I don't know where the source code lives. See e.g. https://github.com/glideapps/quicktype/blob/master/packages/quicktype-typescript-input/src/index.ts |
Odd. I wonder why they don't use this fork. |
There's currently some discussion on the future of schema generators over at vega/ts-json-schema-generator#101.
It's mostly related to uniting the 3 big (and unfortunately buggy) modules that are used for the same purpose (generating JSON schema's from TypeScript sources) together into one, (mostly) feature complete all-round generator.
These 3 modules are:
typescript-json-schema
(this repository)typescript-to-json-schema
at xiag-ag/typescript-to-json-schemasts-json-schema-generator
at vega/ts-json-schema-generatorWe're currently thinking about deprecating this module in favor of vega/ts-json-schema-generator somewhere in the future (for various reasons you can read in the aforementioned issue). However, nothing has really been decided yet and we would love to hear some more opinions on this matter!
The text was updated successfully, but these errors were encountered: