Use indirect reference on tree view tab #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added another commit as I realized Atom will not put tree view into DOM hierarchy if you don't have projects opened. Dynamically observe pane item additions (and fix the tree view tab accordingly) solves the problem. |
|
Thanks for the PR ! I'll take a look at this asap! for now it lgtm but have to test😉 |
|
@noudadrichem Hi Noud, any assistance I could provide to make things smoother? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #48 as it references to tree view tab indirectly (finds the parent element of
.tab[data-type='TreeView']) instead of hiding the first one.Works for me!